Re: [PATCH] Editor file locking

On Wed, 2 Apr 2003, Adam Byrtek / alpha wrote:

> On Wed, Apr 02, 2003 at 11:37:07AM -0500, Pavel Roskin wrote:
> > The patch looks good, but "Steal" and "Continue" looks a bit confusing for
> > a new user.  Maybe "Break lock" and "Ignore lock" would be better?
> Yes, they sound better. 'Steal' and 'continue' was based on JED.

I've applied your patch.  The snapshot is ready.

I had to change the strings.  Please don't use concatenation in
user-visible strings - different languages use different word order.
Also, "file locked by %s" is hard to translate because the translator
doesn't know if %s is a username or PID.  "by" could translate
differently.  Ideally, mc should show all the data separately - host, user
and PID (and maybe timestamp).

One bug that needs to be fixed - if I use Enter to modify the file and I
get a "file locked" message, the old current line is not repainted.  Try
it to see what I mean.

Pavel Roskin

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]