Re: PATCH: IBM AIX patches

[Pavel Machek <pavel suse cz>]

Hi!

> Here is the patch for MC from the official IBM package.
> 
> (From http://www-1.ibm.com/servers/aix/products/aixos/linux/index.html)
> 
> Since I believe that these patches haven't been submitted before I am
> sending them to the respective lists.

> *** gnome1.2/mc-4.5.49/vfs/cpio.c:1.1	Mon Jun 12 16:57:30 2000
> --- gnome1.2/mc-4.5.49/vfs/cpio.c	Tue Sep  5 11:50:06 2000
> ***************
> *** 101,107 ****
>   static int cpio_read(void *fh, char *buffer, int count);
>   
>   #define CPIO_POS(super) cpio_position
> ! //#define CPIO_POS(super) (super)->u.cpio.fd /* If some time reentrancy should be needed */
>   
>   #define CPIO_SEEK_SET(super, where) mc_lseek((super)->u.cpio.fd, CPIO_POS(super) = (where), SEEK_SET)
>   #define CPIO_SEEK_CUR(super, where) mc_lseek((super)->u.cpio.fd, CPIO_POS(super) += (where), SEEK_SET)
> --- 101,107 ----
>   static int cpio_read(void *fh, char *buffer, int count);
>   
>   #define CPIO_POS(super) cpio_position
> ! /* //#define CPIO_POS(super) (super)->u.cpio.fd */ /* If some time reentrancy should be needed */ 

You shoud have removed "//", not leave it there. Ditto few more places.

> diff -c gnome1.2/mc-4.5.49/vfs/tar.c:1.1 gnome1.2/mc-4.5.49/vfs/tar.c:1.2
> *** gnome1.2/mc-4.5.49/vfs/tar.c:1.1	Mon Jun 12 16:57:30 2000
> --- gnome1.2/mc-4.5.49/vfs/tar.c	Tue Sep  5 11:51:03 2000
> ***************
> *** 192,198 ****
>       STATUS_BADCHECKSUM,
>       STATUS_SUCCESS,
>       STATUS_EOFMARK,
> !     STATUS_EOF,
>   } ReadStatus;
>   /*
>    * Return 1 for success, 0 if the checksum is bad, EOF on eof,

What's wrong with this? I thought C allowed leaving "," at the end, and
it is easier to add to list like this.

> --- 192,198 ----
>       STATUS_BADCHECKSUM,
>       STATUS_SUCCESS,
>       STATUS_EOFMARK,
> !     STATUS_EOF
>   } ReadStatus;
>   /*
>    * Return 1 for success, 0 if the checksum is bad, EOF on eof,


-- 
Philips Velo 1: 1"x4"x8", 300gram, 60, 12MB, 40bogomips, linux, mutt,
details at http://atrey.karlin.mff.cuni.cz/~pavel/velo/index.html.