Re: [libxml++] Namespace support in Node::find

[Christophe de VIENNE <cdevienne alphacent com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Le Vendredi 23 Mai 2003 07:54, oystein homelien no a écrit :
> I could not get Node::find to properly find things I were looking for in a
> document with two namespaces in use.  The following patch "fixed it".  Am
> I missing something, or is this missing in libxml++? (please reply
> directly, i am not on the list)

You did not miss anything, it was indeed missing in libxml++. Thanks for 
finding this problem.

> +  if (nsl) {
> +    while (nsl[numns]) {
> +      numns++; // count number of nses
> +    };
> +  };

I'm not sure about this loop.
shouldn't it be :

xmlNsPtr *tmp = nsl;
while(tmp) {
	tmp = tmp->next;
	++numns;
}; 

> +  if (nsl) free(nsl);

I think xmlFreeNsList() is a better choice.


Can you submit a patch (with file ChangeLog updated) into the patch manager ?
http://sourceforge.net/tracker/?group_id=12999&atid=312999

Thanks very much !


Christophe
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE+ziX1B+sU3TyOQjARAreHAJ4izxah+P8WWJS9sHGDE2MOFF/t+QCfTAbw
y/RaAwiNNo2MI3f/bKudLl4=
=Kd03
-----END PGP SIGNATURE-----