RE: [libxml++] Design Issue (was: libxml++ on win32 domparser pro blem)



> Which brings me to the design issue:
> DomParser and Document contain duplicate document access 
> functions which are implemented twice (some even with 
> different names - set_root / create_root).

Yes, I noticed this recently.

> My suggestion is:
> Leave document access functions only in Document.
> DomParser will hold an internal Document instead of having 
> only an xmlDoc. Add a get_document function to DomParser to 
> access the Document.

Yes, that's what I was thinking of doing.

> This is cleaner, without duplication, and solves the 
> initialization problem.

Great. Could you provide a patch. I can't get at the cvs for the next few
days.
 
Murray Cumming
murrayc usa net
www.murrayc.com 




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]