Re: [jokosher-devel] [PATCH] Fixed: Ticket #169 (No way to delete projects from welcome dialog)

[Laszlo Pandy <laszlok2 gmail com>]

Niels Kjøller Hansen wrote:
> Hello all,
>
> This is my first patch for Jokosher, as well as any other project.
>
> I added a button below the 'Open Recent Project' and tied it up to a new
> function in JokosherApp.py called RemoveRecentProject I also added a
> self.model.clear() to PopulateRecentProjects in WelcomeDialog.py to
> empty it before appending the projects.
>
> It seems that my changes to Jokosher.glade has made the patch file very
> large. nibil on #jokosher thinks it's because the latest change was made
> with Glade 2. I used Glade 3.0.2.
>
> Any comments on anything remotely related to the patch are very welcome.

I have talked to you about this on IRC, but I just wanted to let 
everynoe in on the discussion. I would commit this patch (cause the code 
is very good) except that I don't like the big button on the welcome 
dialog. That dialog has enough buttons already and removing the recent 
project is a much less common task then opening a recent project, so it 
should have a smaller button, or it should be more hidden.

There are several other ways to implement this. One of which is to just 
have a clear menu item at the bottom of the recent projects list in the 
file menu. Most other programs do this. That still doesn't make it 
possible to remove it while you are in the welcome dialog, and I haven't 
thought of the best way to do that yet.

Laszlo