Re: new branch (gyrus-python)

[Alejandro Valdes Jimenez <avaldes utalca cl>]

El jue, 15-11-2007 a las 13:13 -0300, Alejandro Valdes Jimenez escribió:
>> Hello,
>> 
>> A new branch has been create in SVN. This branch is the version in pygtk
>> of gyrus.
>>
> I took a quick look to your work in the branch and have some
> questions/comments:

Welcome your comments!

>
> - You moved from the object oriented design of gyrus (with GyrusMainApp,
> GyrusAdmin, and so on) in trunk to a single class with all the code.
> Isn't it that a move backwards regarding the design of the software? Why
> not maintain the code well organized? Python makes it way easier, and I
> suppose that's one of the goals in mind with the language switch.


You are right, I have already changed this situation.


>
> - There's a typo in the name of the file 'constanst_gyrus.py', which
> should be called 'constant_gyrus.py'. 

ups... Renamed. :D


>
> - Also, I'd advocate for some consistency on the file names. See the C
> sources filenames for an example of that.

Attempts to keep the names of the scripts.

>
>Claudio
>-- 
>Claudio Saavedra <csaavedra alumnos utalca cl>

thanks!

-- 
Alejandro Valdés Jiménez.
Ingeniero en Redes y Sistemas.
Area Plataforma
DTI - Dirección de Tecnologías de Información
Universidad de Talca.
Talca - Chile.
Teléfono: (71) 200408  FAX: (71) 200409