Re: prepare_create_table wrapping - part2

[Kjell Ahlstedt <kjellahlstedt gmail com>]

This discussion is perhaps more suitable for a bug report. But if you 
had started with a libgdamm bug, I would not have found it. Anyway, here 
are some comments.

_WRAP_METHOD and many other _WRAP_* macros can only be used in a class 
with a _CLASS_* macro. In this patch it looks like 
ServerOperationCreateTableArg is not included within another class. It 
ought to be possible to use one of the _CLASS_* macros, perhaps 
_CLASS_OPAQUE_COPYABLE.

cnc.operator->()->gobj()? Why not just cnc->gobj()?

Don't ServerOperationCreateTableArg's copy constructors leak memory? 
They assign to _parent several times.


Den 2017-05-13 kl. 18:42, skrev Pavlo Solntsev:
> Dear Kjell.
>
> Thank you so much for pointing on that. I have successfully compiled
> libgdamm. Could you please take a look for CreateTableArg class
> implementation. Is it something we can stay with? I found that
> _WRAP_METHOD doesn't work in this case.
>    
> Thanks.
>
>
> On Sat, 2017-05-13 at 09:53 +0200, Kjell Ahlstedt wrote:
> > You have misspelt CreateTableArgTraits in some places
> > (CreateTableArgTriats), but not everywhere.
> >
> > You can remove the CONVERSION()s to Glib::RefPtr<const
> > ServerOperationCreateTableArg> and
> > Glib::RefPtr<ServerOperationCreateTableArg>. I suppose they are not
> > used, and therefore make no harm.
> >
> > There may be other errors, I haven't studied your code in detail.
> >
> >
> > --
> - Pavlo Solntsev