Re: Using Gtk::Grid in gtkmm-documentation

[Kjell Ahlstedt <kjell ahlstedt bredband net>]

I have a patch for gtkmm-documentation, where Gtk::Table has been 
replaced by Gtk::Grid in all example programs except book/table. I have 
deleted book/table. It's identical to book/grid, except for its use of 
Table instead of Grid.
I have also replaced deprecated classes in gtkmm-tutorial-in.xml (Table, 
HBox, etc).

Can I push this patch?

    Remove Table and other deprecated classes.

    * docs/tutorial/C/gtkmm-tutorial-in.xml: Remove the description of 
Table.
    Replace Table by Grid. Replace the deprecated HX and VX classes 
(HBox etc.)
    by the corresponding X classes (Box etc.).
    * docs/tutorial/C/figures/table.png: Deleted screenshot
    * docs/tutorial/Makefile.am: Don't mention the deleted file.
    * examples/book/assistant/examplewindow.[h|cc]:
    * examples/book/clipboard/ideal/examplewindow.[h|cc]:
    * examples/book/clipboard/simple/examplewindow.[h|cc]:
    * examples/book/printing/advanced/examplewindow.[h|cc]:
    * examples/book/printing/simple/examplewindow.[h|cc]:
    * examples/book/progressbar/examplewindow.[h|cc]:
    * examples/book/scrolledwindow/examplewindow.[h|cc]:
    * examples/others/arrow/direction.cc:
    * examples/others/dnd/dndwindow.[h|cc]:
    * examples/others/tictactoe/tictactoe.cc: Replace Table by Grid.
    * examples/book/drawingarea/joins/myarea.cc: Remove unused variable.
    * examples/others/cellrenderercustom/cellrenderertoggle.cc: Use all 
variables.
    * examples/book/table: Delete directory and all files in it.
    * examples/Makefile.am: Don't mention the deleted files.

Kjell

2012-01-12 11:17, Murray Cumming skrev:
> Sorry. I meant table, not box.
>
> Murray
>
> Kjell Ahlstedt<kjell ahlstedt bredband net>  wrote:
>
> > 2012-01-10 13:41, Murray Cumming skrev:
> > > On Tue, 2012-01-10 at 13:40 +0100, Murray Cumming wrote:
> > > > The latest unstable version of GTK+ deprecates GtkBox, so we should
> > > > replace it with Gtk::Grid in the gtkmm book's examples. Does someone
> > > > have time to do that?
> > > > http://git.gnome.org/browse/gtkmm-documentation
> > > >
> > > > You will know that it's done when you can build gtkmm-documentation with
> > > > the --enable-warnings=fatal configure option.
> > > Actually, when you can run "make check", not just "make".
> > >
> > > > (By the way, I will soon take a day to go through the various
> > > > outstanding patches for gtkmm, libsigc++, etc and deal with them
> > > > properly.)
> > I can do this.
> >
> > When I ran "make check" on code that I fetched from the git repository
> > yesterday, it stopped on a program that uses Gtk::Table. GtkTable is
> > deprecated, but GtkBox is not. Will GtkBox soon be deprecated? Then I
> > will need to replace both Gtk::Box and Gtk::Table by Gtk::Grid.
> >
> > I doubt that "make check" will notice if deprecated classes are
> > mentioned in gtkmm-tutorial-in.xml. That must be checked manually, I guess.
> >
> > If I do this job, do you want me to file a bug report where I describe
> > what I do, or can I just push my commits to git.gnome.org?
> >
> > When I built gtkmm yesterday, the build stopped because main.cc uses
> > some deprecated gtk_key_snooper_* functions.
> >
> > Kjell