Re: ScrolledWindow problem



Gtk::MessageDialog::get_message_area() returns a VBox*, although
gtk_message_dialog_get_message_area() returns a GtkBox* cast to a
GtkWidget*. In the gtk+ documentation it's still called a GtkVBox. Have
they forgotten to change the documentation?

When I searched for [HV]Box, I also saw this code in bin.ccg, where an
HBox* is assigned to Box* vbox:

  //Put them in a VBox:
  Box* vbox = manage(new HBox(false, 5));
  vbox->pack_start(*pmap, PACK_SHRINK);
  vbox->pack_start(*label);
  vbox->show_all();

  //And put that VBox in this:
  add(*vbox);

In the documentation in bin.hg it's called HBox. I suppose the comments
and the variable name in bin.ccg are wrong.

ons 2011-04-20 klockan 18:08 +0200 skrev Murray Cumming:
> On Wed, 2011-04-20 at 17:38 +0200, Kjell Ahlstedt wrote:
> > gtk+/gtk/gtkscolledwindow.c was modified on 2010-10-30 by Javier Jardón
> > with commit "Use gtk_scrollbar_new() instead gtk_[v|h]scrollbar_new()"
> > http://git.gnome.org/browse/gtk
> > +/commit/?id=570b90e218d06da28fb7674c010c73da9427aa9b
> > That commit also modifies gtkmenu.c and gtkwidget.c. And there are more
> > than 10 other commits on the same day, with titles of type "Use
> > gtk_xxx_new() instead gtk_[v|h]xxx_new()". So there is a risk that other
> > classes suffer from similar problems.
> 
> Yes, I've generally been aware of this, but I had missed this one.
> 
> We should probably look through the code for uses of H* and V* classes
> in the API generally. 
> 




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]