Re: Patch for adding VS 2010 property sheet files.

[Tao Wang <dancefire gmail com>]

On Tue, Jul 20, 2010 at 12:20 AM, Armin Burgmeier <armin arbur net> wrote:

On Tue, 2010-07-20 at 00:02 +1000, Tao Wang wrote:
> Hi,
>
> MS VS 2010 doesn't not support .vsprops any more, the new kind of
> thing is .props. MSDN said the previous one is not full XML, the new
> one is. Anyway, I use VS 2010 covert the VS2008 property sheet files
> to VS2010 files. I attached the patch here.

Are you sure this is working correctly? I am somewhat doubtful as the
VS2008 property sheets use gtkmm builds that are linked against the
VS2008 runtime libraries, not the VS2010 ones. I guess we would have to
ship separate binaries for 2010.

You are right. The project can be compiled, but cannot run. I tried 'examples/book/builder'. So, we may need do more to make it work.

On Tue, Jul 20, 2010 at 12:15 AM, David 
King <davidk openismus com> wrote:

On 2010-07-20 00:02, Tao Wang <dancefire gmail com> wrote:

BTW. I'm using TortoiseGit on Windows. I'm not sure why, but it's keep
saying some files has been change totally, just like line ending changes.
However, I didn't found any line ending changed. I reverted them, but It
still complain the changes when I committing. I'm talking about this because
the file 'win32_installer/build-installer' in the patch is only added a few
lines, but the patch shows it's changed every line. Does anyone know why? Is
my TortoiseGit problem?

The old build-installer script has DOS line-endings, the file in your patch has Unix line-endings. http://en.wikipedia.org/wiki/Newline#Representations

I didn't modify the line ending to CRLF. The following files are bothering me:

win32_installer\NSISLibrary\CmdParameters.nsh
win32_installer\NSISLibrary\DetectGTK.nsh
win32_installer\NSISLibrary\IsNT.nsh
win32_installer\NSISLibrary\ParseVersion.nsh
win32_installer\NSISLibrary\PathManipulation.nsh
win32_installer\NSISLibrary\PathQuestion.ini
win32_installer\NSISLibrary\SetContext.ini
win32_installer\NSISLibrary\StringUtilities.nsh
win32_installer\NSISLibrary\VersionCheck.nsh
win32_installer\NSISLibrary\WriteEnvStr.nsh
win32_installer\README
win32_installer\gtkmm-vc80-2_4.vsprops
win32_installer\gtkmm-vc80-d-2_4.vsprops
win32_installer\gtkmm_win32.txt
win32_installer\install-msvc-module
win32_installer\redist_README.txt
win32_installer\translations\english.nsh
win32_installer\translations\french.nsh

I think I understand now. After I turn off 'autocrlf', Git become quiet. At least this time.

-- 
Regards

Tao Wang