Re: gtkmm affected by recent changes to gtk (GdkNativeWindow, gtk_toolbar_[gs]et_tooltips)

[Damon Register <damon w register lmco com>]

Armin Burgmeier wrote:
> I can reproduce the problems you mention when compiling gtkmm against
> GTK+ 2.14.
I feel a little better

> I filed a bug for this:
> http://bugzilla.gnome.org/show_bug.cgi?id=552513. In short, I think the
Thanks

> problem with changing the types appropriately is ABI compatibility. Feel
> free to attach your patch there even if it has some problems yet. It is
> easier to discuss such things on bugzilla.
Ok.  I assume that when you talk of ABI compatibility, you are
talking about the problems you get when running a program built with
one type while using a library built with another type?

------------------------------------------------------------------------------
Here is the patch for the display.h
------------------------------------------------------------------------------

--- display.h	Thu Mar  6 07:33:51 2008
+++ display_fix.h	Tue Sep 16 14:29:04 2008
@@ -466,7 +466,7 @@
    * may be @a xid or the X id of a proxy window, or None if @a xid doesn't
    * support Drag and Drop.
    */
-  guint32 get_drag_protocol(guint32 xid, GdkDragProtocol& protocol);
+  GdkNativeWindow get_drag_protocol(GdkNativeWindow xid, GdkDragProtocol& protocol);


   /**
@@ -487,7 +487,7 @@

   bool set_selection_owner(const Glib::RefPtr<Window>& owner, Glib::ustring& selection, guint32 
time_, bool send_event);
   Glib::RefPtr<Window> get_selection_owner(const Glib::ustring& selection);
-  void selection_send_notify(guint32 requestor, Glib::ustring& selection, Glib::ustring& target, 
Glib::ustring& property, guint32 time_);
+  void selection_send_notify(GdkNativeWindow requestor, Glib::ustring& selection, Glib::ustring& 
target, Glib::ustring& property, guint32 time_);


   /** Looks up the Gdk::Pixmap that wraps the given native pixmap handle.


------------------------------------------------------------------------------
Here is the patch for the display.cc
------------------------------------------------------------------------------

--- display.h	Thu Mar  6 07:33:51 2008
+++ display_fix.h	Tue Sep 16 14:29:04 2008
@@ -466,7 +466,7 @@
    * may be @a xid or the X id of a proxy window, or None if @a xid doesn't
    * support Drag and Drop.
    */
-  guint32 get_drag_protocol(guint32 xid, GdkDragProtocol& protocol);
+  GdkNativeWindow get_drag_protocol(GdkNativeWindow xid, GdkDragProtocol& protocol);


   /**
@@ -487,7 +487,7 @@

   bool set_selection_owner(const Glib::RefPtr<Window>& owner, Glib::ustring& selection, guint32 
time_, bool send_event);
   Glib::RefPtr<Window> get_selection_owner(const Glib::ustring& selection);
-  void selection_send_notify(guint32 requestor, Glib::ustring& selection, Glib::ustring& target, 
Glib::ustring& property, guint32 time_);
+  void selection_send_notify(GdkNativeWindow requestor, Glib::ustring& selection, Glib::ustring& 
target, Glib::ustring& property, guint32 time_);


   /** Looks up the Gdk::Pixmap that wraps the given native pixmap handle.

------------------------------------------------------------------------------

> The problem is not the all-in-one GTK+ package, but these few lines at
> the top of toolbar.ccg:
>
> #define GTK_DISABLE_DEPRECATED
Thanks for pointing that out.  Now I see.

> This has already been fixed in gtkmm 2.13.8, though.
Great.  Now I have just the one problem.

Damon Register