GNOME.org
 

Gtkmm-forge Digest, Vol 11, Issue 5

Send Gtkmm-forge mailing list submissions to
	gtkmm-forge lists sourceforge net

To subscribe or unsubscribe via the World Wide Web, visit
	https://lists.sourceforge.net/lists/listinfo/gtkmm-forge
or, via email, send a message with subject or body 'help' to
	gtkmm-forge-request lists sourceforge net

You can reach the person managing the list at
	gtkmm-forge-owner lists sourceforge net

When replying, please edit your Subject line so it is more specific
than "Re: Contents of Gtkmm-forge digest..."


gtkmm-forge is the mailing list that receives gtkmm bug reports from bugzilla.  A daily digest is sent to gtkmm-main, to encourage people to help fixing the bugs. Do not try to unsubscribe gtkmm-forge from gtkmm-list.


Today's Topics:

   1. [Bug 339791] Gtk::Menu crash with child
      (gtkmm (bugzilla.gnome.org))
   2. [Bug 339791] Gtk::Menu crash with child
      (gtkmm (bugzilla.gnome.org))
   3. [Bug 378810] Extra signals documentation not used
      (glibmm (bugzilla.gnome.org))
   4. [Bug 378810] Extra signals documentation not used
      (glibmm (bugzilla.gnome.org))
   5. [Bug 339791] Gtk::Menu crash with child
      (gtkmm (bugzilla.gnome.org))
   6. [Bug 339791] Gtk::Menu crash with child
      (gtkmm (bugzilla.gnome.org))
   7. [Bug 339791] Gtk::Menu crash with child
      (gtkmm (bugzilla.gnome.org))
   8. [Bug 419923] No key press events signals for some	keys
      (gtkmm (bugzilla.gnome.org))


----------------------------------------------------------------------

Message: 1
Date: Tue, 10 Apr 2007 09:44:56 +0000 (UTC)
From: "gtkmm (bugzilla.gnome.org)"
	<bugzilla-daemon bugzilla gnome org>
Subject: [gtkmm bugzilla] [Bug 339791] Gtk::Menu crash with child
To: gtkmm-forge lists sourceforge net
Message-ID: <20070410094456 112C86C429F box gnome org>
Content-Type: text/plain; charset=utf-8

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=339791

  gtkmm | general | Ver: 2.8.x

Johannes Schmid changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jhs gnome org




------- Comment #24 from Johannes Schmid  2007-04-10 09:44 UTC -------
OK, after two hours of debugging I think I know what happens:

The child_submenu is destroyed because gtk_menu_item_destroy destroys it
unconditionally as Paul already pointed out.
The menuitem is destroyed because the GtkContainer (parent of the
menushell/menu) is destroyed.
The GtkMenuShell uses the GtkContainer interface to manage its GtkMenuItems and
thus all GtkMenuItems part of a Menu are destroyed once the GtkMenu is
destroyed and the MenuItems destroy their submenus.

The questions:
So, the submenu is dead before we call "delete m_child"! So either we prevent
Gtk::MenuItem from destroying its submenu or we have to document this somehow.  

Of course we can, as Paul already showed, detach the submenu before the
Gtk::MenuItem is destroyed but what about the 99% cases were we would want that
the submenu is destroyed with the parent?


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=339791.



------------------------------

Message: 2
Date: Tue, 10 Apr 2007 15:00:09 +0000 (UTC)
From: "gtkmm (bugzilla.gnome.org)"
	<bugzilla-daemon bugzilla gnome org>
Subject: [gtkmm bugzilla] [Bug 339791] Gtk::Menu crash with child
To: gtkmm-forge lists sourceforge net
Message-ID: <20070410150009 133EF6C4286 box gnome org>
Content-Type: text/plain; charset=utf-8

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=339791

  gtkmm | general | Ver: 2.8.x




------- Comment #25 from Paul Davis  2007-04-10 15:00 UTC -------
Its been quite a while, but I thought calling detach() would take care of
automatically deleting when the submenu was managed.

Let me iterate its been a long time since I looked at this though.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=339791.



------------------------------

Message: 3
Date: Wed, 11 Apr 2007 16:20:46 +0000 (UTC)
From: "glibmm (bugzilla.gnome.org)"
	<bugzilla-daemon bugzilla gnome org>
Subject: [gtkmm bugzilla] [Bug 378810] Extra signals documentation not
	used
To: gtkmm-forge lists sourceforge net
Message-ID: <20070411162046 D9BD06C41E0 box gnome org>
Content-Type: text/plain; charset=utf-8

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=378810

  glibmm | documentation | Ver: unspecified




------- Comment #1 from Armin Burgmeier  2007-04-11 16:20 UTC -------
Created an attachment (id=86177)
 --> (http://bugzilla.gnome.org/attachment.cgi?id=86177&action=view)
Proposed patch

This patch does basically the following: First, it adds '/**' as a separate
token that is handled different to '/*'. When the closing '*/' of a '/**'
comment is encountered, it checks whether a _WRAP_SIGNAL follows. If so, it
does not close the comment but calls on_wrap_signal on its own with a new
boolean parameter that says that there was already a previous command. The
Outputter eventually gets that parameter. If it is set, then it strips away the
leading '/**' from the refdoc comment to merge it with the already-encountered
manual comment.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=378810.



------------------------------

Message: 4
Date: Wed, 11 Apr 2007 16:24:26 +0000 (UTC)
From: "glibmm (bugzilla.gnome.org)"
	<bugzilla-daemon bugzilla gnome org>
Subject: [gtkmm bugzilla] [Bug 378810] Extra signals documentation not
	used
To: gtkmm-forge lists sourceforge net
Message-ID: <20070411162426 D92FE6C419C box gnome org>
Content-Type: text/plain; charset=utf-8

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=378810

  glibmm | documentation | Ver: unspecified

Armin Burgmeier changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |armin arbur net




-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=378810.



------------------------------

Message: 5
Date: Wed, 11 Apr 2007 22:27:07 +0000 (UTC)
From: "gtkmm (bugzilla.gnome.org)"
	<bugzilla-daemon bugzilla gnome org>
Subject: [gtkmm bugzilla] [Bug 339791] Gtk::Menu crash with child
To: gtkmm-forge lists sourceforge net
Message-ID: <20070411222707 513F26C4287 box gnome org>
Content-Type: text/plain; charset=utf-8

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=339791

  gtkmm | general | Ver: 2.8.x




------- Comment #26 from Johannes Schmid  2007-04-11 22:27 UTC -------
Created an attachment (id=86205)
 --> (http://bugzilla.gnome.org/attachment.cgi?id=86205&action=view)
Patch for the issue

This patch is based on Paul's work and uses the on_parent_changed()-vfunc of
Gtk::Menu to ensure the Menu is not destroyed together with it's MenuItem.

I tested this will all testcases that are available here and also checked if it
works with Gtk::manage(). Everything worked as expected so I think this
solution would be OK. As I explained earlier I don't think that changing the
behaviour in Gtk+ would make sense.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=339791.



------------------------------

Message: 6
Date: Thu, 12 Apr 2007 00:23:00 +0000 (UTC)
From: "gtkmm (bugzilla.gnome.org)"
	<bugzilla-daemon bugzilla gnome org>
Subject: [gtkmm bugzilla] [Bug 339791] Gtk::Menu crash with child
To: gtkmm-forge lists sourceforge net
Message-ID: <20070412002300 0307B6C4286 box gnome org>
Content-Type: text/plain; charset=utf-8

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=339791

  gtkmm | general | Ver: 2.8.x




------- Comment #27 from Paul Davis  2007-04-12 00:22 UTC -------
There's something not right here...

I've spent a couple hours reading up on what was actually causing this bug. If
I have everything right in my head, the bug can be boiled down to this:

GtkMenuItem unconditionally destroy's its submenu.

Have we brought this up on the Gtk list to see what their response was? My
feeling is that the submenu in GtkMenuItem should be treated like a
container/child relationship, but the way the Gtk code is written, it appears
to be more of a sole owner relationship.

The more I think about it the more I dislike the Gtk::Menu::on_parent_changed()
patch. It would seem to me that we're implicitly assuming that the parent will
always be a Gtk::MenuItem. I can't point to a specific test case, but it seems
like this assumption could bite us in the ass when its invalid.

First things first, I think we should bring this up on the Gtk list and see
what they have to say.  Maybe its a bug and it'll get fixed there.

If its expected behavior, then I'm thinking that we should be looking at a
patch for the Gtk::MenuItem destructor, which could be a call to
submenu->detach() or something.

Anyway, those are my thoughts for right now.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=339791.



------------------------------

Message: 7
Date: Thu, 12 Apr 2007 07:59:01 +0000 (UTC)
From: "gtkmm (bugzilla.gnome.org)"
	<bugzilla-daemon bugzilla gnome org>
Subject: [gtkmm bugzilla] [Bug 339791] Gtk::Menu crash with child
To: gtkmm-forge lists sourceforge net
Message-ID: <20070412075901 D8E006C42AD box gnome org>
Content-Type: text/plain; charset=utf-8

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=339791

  gtkmm | general | Ver: 2.8.x

Johannes Schmid changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #86205|none                        |needs-work
               Flag|                            |




------- Comment #28 from Johannes Schmid  2007-04-12 07:59 UTC -------
Hi Paul!

Yes, I see your point! I have written a mail to gtk-devel-list (CC'd you), we
will see what they say.

A menu can be attached to any widget but I assume no widget other than
GtkMenuItem destroys the menu.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=339791.



------------------------------

Message: 8
Date: Thu, 12 Apr 2007 11:10:24 +0000 (UTC)
From: "gtkmm (bugzilla.gnome.org)"
	<bugzilla-daemon bugzilla gnome org>
Subject: [gtkmm bugzilla] [Bug 419923] No key press events signals for
	some	keys
To: gtkmm-forge lists sourceforge net
Message-ID: <20070412111024 C7F866C421F box gnome org>
Content-Type: text/plain; charset=utf-8

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=419923

  gtkmm | general | Ver: 2.4

Armin Burgmeier changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |armin arbur net




------- Comment #5 from Armin Burgmeier  2007-04-12 11:10 UTC -------
The problem here is that g_signal_connect connects before the default signal
handler runs and gtkmm signals connect after (by default). Using
g_signal_connect_after in the C testcase yields the same result as the C++
version, and using win.signal_key_press_event().connect(sigc::ptr_fun(...),
false) in the C++ testcase results in the same behaviour as in the C version.

Probably, the default signal handler of the key press event returns TRUE for
some keys and therefore prevents other handlers from being run. However, this
is not a gtkmm issue. Perhaps a GTK+ one, but I think it is OK the way it is.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=419923.



------------------------------

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

------------------------------

_______________________________________________
Gtkmm-forge mailing list
Gtkmm-forge lists sourceforge net
https://lists.sourceforge.net/lists/listinfo/gtkmm-forge


End of Gtkmm-forge Digest, Vol 11, Issue 5
******************************************
[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]