Compile Error on FC5 (was "Re: gtkdatabox-0.8.0.0 released")

[Roland Bock <box2OO6 eudoxos de>]

Hi Eric,

thanks for the patch!

The patch worked fine for me and a new version is uploaded. I must admit
that I am a bit confused that that was necessary, because I created the
file using a glib tool:


glib-genmarshal --header --prefix=gtk_databox_marshal --internal
gtkdatabox_marshal.list

glib-genmarshal --body --prefix=gtk_databox_marshal  --internal
gtkdatabox_marshal.list

The header seems to be just fine, containing the "G_GNUC_INTERNAL" from
your patch, but the C file does not contain it.


Can you try to run the glib-genmarshal on your machine and see if it
produces code that works for you? In that case I think of removing the
gtkdatabox_marshal.[ch]. The files would be created by the make process.


Regards,

Roland

Eric Work wrote:
> With the help of fedora developers they came up with a patch to fix
> the compile errors.  The patch is attached.
> 
> -Eric
> 
> On Nov 26, 2007 1:17 PM, Eric Work <work eric gmail com> wrote:
>> Sorry, here is the build log.
>>
>> http://koji.fedoraproject.org/koji/getfile?taskID=259814&name=build.log
>>
>> -Eric
>>
>>
>> On Nov 26, 2007 1:15 PM, Eric Work <work eric gmail com> wrote:
>>> You mentioned on your website that gtk+ 2.8 or newer is required.  You
>>> should also mention that pango 1.16 or newer is required.  The latest
>>> version will not build on FC5 for FC6 despite having gtk+ 2.8 or
>>> newer.  For some reason it will also not build on x86_64 against
>>> rawhide, looks like a toolchain problem.  I've sent an email to fedora
>>> developers to get their opinion.  I'll keep you updated.
>>>
>>> -Eric
>>>
>>>
>>> On Nov 26, 2007 3:31 AM, Roland Bock <box2OO6 eudoxos de> wrote:
>>>> Hi Fabian,
>>>>
>>>> thanks for the feedback :-)
>>>>
>>>> An updated version (0.8.0.1) is online now and takes care of your
>>>> suggestions.
>>>>
>>>> Regards,
>>>>
>>>> Roland
>>>>
>>>>
>>>> Fabian Foerg wrote:
>>>>> Thank you very much Roland, this release is great.
>>>>> In future versions of cournol, I'll use gtkdatabox_rulers instead of
>>>>> nxp_rulers.
>>>>> Here the new version works flawlessly, but nevertheless, I have two
>>>>> small suggestions:
>>>>>
>>>>> 1) In gtkdatabox.c, line 1352, <gtk/gtkdatabox_ruler.h> is included.
>>>>> Actually, <gtkdatabox_ruler.h> should be included.
>>>>>
>>>>> 2) In examples/basics2.c a few unused variables can be found. From the
>>>>> gcc output:
>>>>> basics2.c: In Funktion »create_basics«:
>>>>> basics2.c:57: Warnung: Variable »buffer« wird nicht verwendet
>>>>> basics2.c:54: Warnung: Variable »max« wird nicht verwendet
>>>>> basics2.c:53: Warnung: Variable »min« wird nicht verwendet
>>>>> basics2.c:51: Warnung: Variable »ruler« wird nicht verwendet
>>>>> basics2.c:50: Warnung: Variable »scrollbar« wird nicht verwendet
>>>>>
>>>>> Regards,
>>>>> Fabian
>>>>>
>>>>>
>>>>> Roland Bock wrote:
>>>>>> Dear all,
>>>>>>
>>>>>> a few minutes ago I uploaded a new version of GtkDatabox:
>>>>>>
>>>>>> http://www.eudoxos.de/gtk/gtkdatabox/download/gtkdatabox-0.8.0.0.tar.gz
>>>>>>
>>>>>> Here is the appropriate excerpt from the ChangeLog:
>>>>>>
>>>>>> <snip>
>>>>>> - Added support for logarithmic scales for drawing
>>>>>> - Replaced original gtkruler with gtkdatabox_ruler.
>>>>>> - GtkDataboxRuler supports logarithmic scales
>>>>>> - Instead of HRuler and VRuler, GtkDataboxRuler has an orientation
>>>>>>   - No big changes in existing projects required, see examples
>>>>>> - renamed the following functions:
>>>>>>   gtk_databox_get_canvas         => gtk_databox_get_total_limits
>>>>>>   gtk_databox_set_canvas         => gtk_databox_set_total_limits
>>>>>>   gtk_databox_get_visible_canvas => gtk_databox_get_visible_limits
>>>>>>   gtk_databox_set_visible_canvas => gtk_databox_set_visible_limits
>>>>>> - replaced GtkDataboxCoord by GdkPoint (which is just the same)
>>>>>> - Added example which shows linear, logarithmic and double logarithmic
>>>>>>   graphs
>>>>>> - Added example which shows easiest way to start with GtkDatabox
>>>>>> </snip>
>>>>>>
>>>>>> I hope I have not forgotten any important thing...
>>>>>>
>>>>>> Some more words about the rulers:
>>>>>> We had a discussion about using nxp_ruler, which seemed to have both,
>>>>>> good handling of huge values and logarithmic scales. But when I took a
>>>>>> closer look there were a few things that stopped me from using nxp_rulers:
>>>>>>
>>>>>> *) Scales cannot not be inverted, so I cannot turn my graph upside down.
>>>>>> This is an old and required feature of GtkDatabox, though.
>>>>>>
>>>>>> *) I do not understand the code that calculates the ticks at all.
>>>>>>
>>>>>> *) Two many classes for my taste (3 rulers, plus a special adjustment)
>>>>>>
>>>>>> *) There were some minor issues in addition
>>>>>>
>>>>>> I therefore took a look at the "original" GtkRuler, again. I liked that
>>>>>> code much better and adjusted it to create a GtkDataboxRuler widget
>>>>>> which (in my eyes) combines the benefits of GtkRuler and NxpRuler and more:
>>>>>>
>>>>>> *) Works with rather big and also rather small data ranges
>>>>>>
>>>>>> *) Supports linear and logarithmic scales
>>>>>>
>>>>>> *) Can be inverted
>>>>>>
>>>>>> *) Only one class (not three or four)
>>>>>>
>>>>>> *) Modern GTK Style, using cairo (maybe this also should be used with
>>>>>> some of the graphs)
>>>>>>
>>>>>>
>>>>>> You see, I like it ;-)
>>>>>>
>>>>>>
>>>>>> I am looking forward to reading your feedback!
>>>>>>
>>>>>>
>>>>>> Regards,
>>>>>>
>>>>>> Roland
>>>>>>
>>>>>> _______________________________________________
>>>>>> gtkdatabox-list mailing list
>>>>>> gtkdatabox-list gnome org
>>>>>> http://mail.gnome.org/mailman/listinfo/gtkdatabox-list
>>>>>>
>>>>> _______________________________________________
>>>>> gtkdatabox-list mailing list
>>>>> gtkdatabox-list gnome org
>>>>> http://mail.gnome.org/mailman/listinfo/gtkdatabox-list
>>>>>
>>>> _______________________________________________
>>>> gtkdatabox-list mailing list
>>>> gtkdatabox-list gnome org
>>>> http://mail.gnome.org/mailman/listinfo/gtkdatabox-list
>>>>
>>
>> ------------------------------------------------------------------------
>>
>> _______________________________________________
>> gtkdatabox-list mailing list
>> gtkdatabox-list gnome org
>> http://mail.gnome.org/mailman/listinfo/gtkdatabox-list