Re: gvncviewer improvement - input grab problems

["Daniel P. Berrange" <dan berrange com>]

On Fri, Aug 21, 2009 at 06:44:01PM +0200, Michal Suchanek wrote:
> 2009/8/21 Daniel P. Berrange <dan berrange com>:
> > On Fri, Aug 21, 2009 at 08:50:07AM -0300, Jonh Wendell wrote:
> >> Em Sáb, 2009-08-08 às 16:02 +0200, Michal Suchanek escreveu:
> >> > The drawback which is easily resolved is that with gvncviewer one
> >> > cannot specify local vnc server by display number only.
> >>
> >> I agree with this patch, I've done something similar in vinagre, BTW.
> >>
> >> > There is also another issue that the vnc viewer reports "disconnected
> >> > from server" when it in fact did not manage to connect at all.
> >>
> >> I think we should do this one in VncDisplay widget, so that all clients
> >> benefit from it. We could add another signal, say, "connect-error" to
> >> the widget, or just add another parameter, "reason", to current
> >> "vnc-disconnected" signal.
> >>
> >> Dan, what do you think?
> >
> > Yeah, I reckon we should have a 'vnc-notconnected' signal in the case
> > where it fails to connect at all
> 
> Adding a new signal would mean that old clients would not receive the
> vnc-disconnected (or whatever) signal and won't suspect a thing.

That's a good point. One other annoying thing about existing signal,
is that there's no way to discover what caused it, whether the connection
closed by client request (vnc_display_close), or because of an I/O
error. As such we should perhaps consider adding a method

  GError *vnc_display_get_last_error(VncDisplay *vnc)


In the case of failing to connect, you'd thus be able to query the error
and see the 'connection refused', or 'unknown hostname', or 'invalid
SSL certificate' errors, etc.

This would also ensure backcompat with existing usage

Daniel
-- 
|: http://berrange.com/     -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://freshmeat.net/~danielpb/    -o-   http://gtk-vnc.sourceforge.net :|