[gtk-vnc-devel] [PATCH] Clear up LIBS/LDFLAGS confusion in configure.ac



I was wondering why ./configure couldn't detect the presence of the
gdk_cairo_create function, which is present and works perfectly on
Windows.

It turned out, after a bit of detective work by myself and Jim
Meyering, that it's because configure.ac abuses LDFLAGS where it
should use LIBS.  This probably has no effect on "normal" platforms,
but stops the conftest program from linking under our MinGW cross-
compiler.

The attached patch clears up the confusion.

Rich.

-- 
Richard Jones, Emerging Technologies, Red Hat  http://et.redhat.com/~rjones
Read my OCaml programming blog: http://camltastic.blogspot.com/
Fedora now supports 68 OCaml packages (the OPEN alternative to F#)
http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora
diff -r 47135c91cd9c configure.ac
--- a/configure.ac	Thu Oct 09 11:23:09 2008 -0400
+++ b/configure.ac	Wed Oct 29 17:35:22 2008 +0000
@@ -116,11 +116,14 @@
 
 save_CFLAGS="$CFLAGS"
 save_LDFLAGS="$LDFLAGS"
+save_LIBS="$LIBS"
 CFLAGS="$CFLAGS $GTK_CFLAGS"
-LDFLAGS="$LDFLAGS $GTK_LIBS"
+LDFLAGS="$LDFLAGS $GTK_LDFLAGS"
+LIBS="$LIBS $GTK_LIBS"
 AC_CHECK_FUNC([gdk_cairo_create], [WITH_GTK_CAIRO=1], [WITH_GTK_CAIRO=0])
 CFLAGS="$save_CFLAGS"
 LDFLAGS="$save_LDFLAGS"
+LIBS="$save_LIBS"
 
 AC_DEFINE_UNQUOTED(WITH_GTK_CAIRO, [$WITH_GTK_CAIRO], [Whether to use cairo for GTK rendering])
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]