Re: [gtk-vnc-devel] [PATCH] Clear up LIBS/LDFLAGS confusion in configure.ac

["Daniel P. Berrange" <berrange redhat com>]

On Wed, Oct 29, 2008 at 05:42:59PM +0000, Richard W.M. Jones wrote:
> 
> I was wondering why ./configure couldn't detect the presence of the
> gdk_cairo_create function, which is present and works perfectly on
> Windows.
> 
> It turned out, after a bit of detective work by myself and Jim
> Meyering, that it's because configure.ac abuses LDFLAGS where it
> should use LIBS.  This probably has no effect on "normal" platforms,
> but stops the conftest program from linking under our MinGW cross-
> compiler.
> 
> The attached patch clears up the confusion.
> 
> Rich.
> 
> -- 
> Richard Jones, Emerging Technologies, Red Hat  http://et.redhat.com/~rjones
> Read my OCaml programming blog: http://camltastic.blogspot.com/
> Fedora now supports 68 OCaml packages (the OPEN alternative to F#)
> http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora

> diff -r 47135c91cd9c configure.ac
> --- a/configure.ac	Thu Oct 09 11:23:09 2008 -0400
> +++ b/configure.ac	Wed Oct 29 17:35:22 2008 +0000
> @@ -116,11 +116,14 @@
>  
>  save_CFLAGS="$CFLAGS"
>  save_LDFLAGS="$LDFLAGS"
> +save_LIBS="$LIBS"
>  CFLAGS="$CFLAGS $GTK_CFLAGS"
> -LDFLAGS="$LDFLAGS $GTK_LIBS"
> +LDFLAGS="$LDFLAGS $GTK_LDFLAGS"

There is no such GTK_LDFLAGS variable only GTK_LIBS, so
all the LDFLAGS stuff should just be remove


Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|