Re: [gtk-vnc-devel] PATCH: make keyboard & pointer grabs configurable

["Daniel P. Berrange" <berrange redhat com>]

On Mon, Jul 09, 2007 at 09:36:16AM -0500, Anthony Liguori wrote:
> Daniel P. Berrange wrote:
> >On Mon, Jul 09, 2007 at 09:08:22AM -0500, Anthony Liguori wrote:
> >  
> >>Daniel P. Berrange wrote:
> >>    
> >>>>One of the obvious reasons for that is that there is one "release grab"
> >>>>hotkey only.
> >>>>   
> >>>>        
> >>>Two primary scenarios I have
> >>>
> >>> - Grab both  keyboard & mouse at same time - upon first click - in this
> >>>   case there's  only a single ungrab hotkey needed
> >>> - Grab keyboard only when mouse is over the VNC widget - there's no
> >>>   ungrab hotkey needed at all - simply move the mouse outside the
> >>>   widget
> >>> 
> >>>      
> >>So this should be an option within gtk-vnc instead of being something 
> >>implemented externally to it.  I agree that you really don't want 
> >>keyboard grab exposed as a separate option except for this one very 
> >>special case.
> >>    
> >
> >The trouble is there's no way for the VNC widget to determine which grab
> >mode it needs to operate in.
> 
> Ignore my earlier comments.  I didn't read your patch thoroughly enough 
> as it's doing what I think should be done.  Should make sure to get 
> caffeine in my system before looking at patches :-)

Ok, this is pushed now.

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=|