Re: [gtk-vnc-devel] PATCH 1/2: Lifecycle re-factoring

["Daniel P. Berrange" <berrange redhat com>]

On Mon, Jul 09, 2007 at 09:01:31AM -0500, Anthony Liguori wrote:
> Daniel P. Berrange wrote:
> >This first patch is just a little re-factoring to make the next patch
> >easier. 
> >
> >  - It makes all the gvnc related structs start with 'gvnc_' just for
> >    sake of consistency.
> >
> >  - The gvnc_connect_* methods no longer actually allocate the gvnc
> >    data structure. They operate on a pre-existing object
> >
> >  - A new gvnc_new method is avialable for allocating the struct
> >
> >  - The gvnc_ops struct of callbacks is passed into the gvnc_new method
> >    straight away. This is because we need the callback right from the
> >    start for authentication callbacks
> >
> >  - A gvnc_close() method can be used to free up data & reset internal
> >    state ready for opening a new connection
> >
> >  - Adds in the vnc-disconnected  signal to vnc_display
> >  
> 
> In the future, it would be nice to split out some of these things into 
> separate patches to make them easier to review.   This changeset looks 
> good though.

Yeah, I should have separated out the struct renaming from the close/new/open
changes  This is pushed.

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=|