Re: [gtk-vnc-devel] PATCH: Clear areas outside of framebuffer region

["Daniel P. Berrange" <berrange redhat com>]

On Wed, Aug 22, 2007 at 01:58:50PM -0500, Anthony Liguori wrote:
> 
> On Wed, 2007-08-22 at 15:19 -0300, Jonh Wendell wrote:
> > Em Qua, 2007-08-22 às 17:52 +0100, Daniel P. Berrange escreveu:
> > > If the GTK-VNC widget gets resized to be larger than the region taken up
> > > by the remote framebuffer, the excess space just gets filled with random
> > > garbage.  This is seen in Vinagre if you hit "Full Screen"
> > > 
> > > The attached patch calls gdk_draw_rectangle to fill the excess space with
> > > a solid colour (black). It uses a clip mask to ensure we don't clear the
> > > space where the actual framebuffer is & thus avoids flickr that would entail.
> > 
> > The patch worked fine to me.
> > 
> > BTW, What do you think about putting the widget in the middle of area,
> > instead of top left?
> > 
> > And, when will we have scaling support? :) hehe
> 
> I've got an initial patch but it's not performing as well as I'd like it
> to.  I'll get to spend some time on it again post KVM forum.

I was wondering if it was worth using cairo to render the pixmap instead
of directly calling gdk_draw_image. With cairo one can set a scaling 
factor and (in theory) cairo will scale the pixmap appropriately  and
efficiently when blatting it to the X server. Getting pixel perfect
renderering for the 1-to-1 case may be interesting, but might be worth
prototyping at lesat.  Might also make it easier to make use of hardware
acceleration - just use an OpenGL cairo context instead of a GDK one.

(Disclaimer, I've never used cairo seriously, let alone OpenGL :-)

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=|