Re: Patch for Gtk3

[Torsten Schoenfeld <kaffeetisch gmx de>]

On 28.05.2016 07:44, Maximilian Lika wrote:
> To which mailing list? Here? And how can I submit a patch to the mailing
> list? I give a try :-) 
> Enclosed you find the patched Gtk3.pm file.

Sending patch files is fine, preferably in "diff -u" or "git
format-patch" format.  Sending the whole new file is not necessary.

> The output of the command diff ./Gtk3.pm ./Gtk3-patch.pm is here:
>
> 299,300c299,300
> <   my ($dialog, $id) = @_;
> <   return ($dialog, $_GTK_RESPONSE_ID_TO_NICK->($id));
> ---
> >   my ($dialog, $id, $userdata) = @_;
> >   return ($dialog, $_GTK_RESPONSE_ID_TO_NICK->($id), $userdata);

This looks fine to me, but you can be bothered to also update the unit
tests to ensure this does not get broken again?  Good places would be
around here:

https://git.gnome.org/browse/perl-Gtk3/tree/t/zz-GtkDialog.t#n53
https://git.gnome.org/browse/perl-Gtk3/tree/t/zz-GtkInfoBar.t#n46