Re: Patch for Gtk3



Dear Brian,

To which mailing list? Here? And how can I submit a patch to the mailing
list? I give a try :-) 
Enclosed you find the patched Gtk3.pm file.
The output of the command diff ./Gtk3.pm ./Gtk3-patch.pm is here:

299,300c299,300
<   my ($dialog, $id) = @_;
<   return ($dialog, $_GTK_RESPONSE_ID_TO_NICK->($id));
---
  my ($dialog, $id, $userdata) = @_;
  return ($dialog, $_GTK_RESPONSE_ID_TO_NICK->($id), $userdata);

the target of the patch is allowing to pass additional arguments and
userdatas to the callback function connected to the response signal of a
Gtk3::Dialog as in
https://developer.gnome.org/gtk3/stable/GtkDialog.html#GtkDialog-response forseen. Through the 
Gtk3::Dialog::_gtk3_perl_response_converter function they are unfortunately cut off at the moment.

Best wishes,
Max

Am Freitag, den 27.05.2016, 10:27 -0700 schrieb Brian Manning:
On Fri, May 27, 2016 at 1:45 AM, <max augsburg gmx de> wrote:

Dear Brian,
dear perl-Gtk3 Maintainer,
I read just now, that patch submission shall be done by E-Mailing it to the mailing list. Sorry for that. 
I have sent a little proposal to your github account here: https://github.com/GNOME/perl-Gtk3/pull/1

Hi,

I have no access to this account, it's not my account, and I don't
know who it belongs to.  They do have a FAQ page at
https://wiki.gnome.org/Sysadmin/GitHub, and it says:

Q: Will pull requests and issues be accepted?

A: No, they won't be accepted.

FYI, the official Git repo for the Perl Gtk3 module is at:

https://git.gnome.org/browse/perl-Gtk3/

Could you delete the pull request that you created, and submit a patch
to the mailing list instead?

Thanks,

Brian

Attachment: Gtk3-patch.pm
Description: Perl program



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]