Re: An introspection fix & a Gtk3 test

[Brian Manning <cpan xaoc org>]

On Tue, Sep 3, 2013 at 7:18 PM, Zach Morgan <zpmorgan gmail com> wrote:
> Hello, list!
>
> I've made a couple changes that I'd like to propagate to your gnome
> repositories. The issue was that TextIter's find_char methods weren't
> working because Introspection couldn't handle the unicode character
> type.
>
> https://github.com/zpmorgan/perl-Gtk3/commit/101fba260d99e3ef1270278e3fa332de2957be24
> https://github.com/zpmorgan/gi/commit/fcf90564255c9b870cea9fc2daa0c118091eaaaa

Hi.

I've added these two changes to my personal repos [1][2] on GitHub for
further review.

The patches looked fine to me, however, I have limited experience with
Gtk3 internals, so I would like more review before I push to
git.gnome.org.

I also tentatively bumped the required version of
Glib::Object::Inspection in Gtk3 to be 0.016, which would correspond
to the next release of G:O:I.  If anyone else wants to pick up these
changes, you will need to get both modules, and build and install a
new copy of G:O:I first prior to building Gtk3.

If you (or anyone else for that matter) want to submit more changes,
please feel free to fork these repos on GitHub and send me a pull
request with your changes.

Thanks for spotting this and chasing it down!

Brian

[1] https://github.com/cpanxaoc/perl-Gtk3
[2] https://github.com/cpanxaoc/perl-Glib-Object-Introspection