Re: failed test when installing Cairo on windows
- From: rahed <raherh gmail com>
- To: gtk-perl-list gnome org
- Subject: Re: failed test when installing Cairo on windows
- Date: Sat, 29 Dec 2007 13:31:44 +0000
"T.J. Ferraro" <tjtoocool phreaker net> writes:
*alloc/free is not safe. You should be using New* and Safefree for
*alloc/free calls. I remember the same problem being resolved in
DBD-Pg a little while back. The attached diff is against 1.044. At
first I only changed the calloc/free calls, which were responsible for
the test failure on windows. But then I also noticed you had 4
malloc/free calls lying around. Although they were causing no test
failures I figured while I was at it I might as well fix those, as
well. Feel free to drop those changes if you disagree =)
I applied the patch to my distribution with this result:
t/Cairo...........ok
12/68 skipped: various reasons
t/CairoFont.......ok
t/CairoMatrix.....ok
t/CairoPath.......ok
t/CairoPattern....ok
8/25 skipped: various reasons
t/CairoSurface....libpng error: Write Error
libpng error: Write Error
libpng error: Read Error
ok
All tests successful, 20 subtests skipped.
Files=6, Tests=191, 1 wallclock secs ( 0.00 cusr + 0.00 csys = 0.00 CPU)
Thank you.
--
Radek
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]