Re: [PATCH] Gnome2::VFS::read_entire_file crashes on failure

muppet said:
when gnome_vfs_read_entire_file() fails to load a file (is a directory,
for example) file_contents and file_size both get zeroed.  the bindings
were passing the NULL file_contents on to newSVpv(), but since file_size
is zero, newSVpv() thinks we want it to calculate the string's size for
us, and passes the NULL pointer to strlen().  strlen() doesn't like NULL

the attached patch fixes it.

thanks to gavin for stumbling upon this issue.

looks good to me.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]