Re: yap - Gtk2::FileSelector

[Ross McFarland <rwmcfa1 neces com>]

On Thu, 2003-04-17 at 18:24, Chas Owens wrote:
> Again, a little thievery and cleaning up.
>
> BTW: should it be considered a bug that $fs->complete doesn't actually
> cause the file list to be filtered (you have to hit tab)?  The same thing
> happens in Gtk#, so I know it isn't a Gtk-Perl-XS problem.

don't know if this is a bug or not, but after looking at the
gtk2-perl-xs code, it's not at the gtk2-perl-xs level. we have a simple
and straightforward mapping for that function so it's very unlikely we
could be causing the problem. i'll look into it when i get a chance. (at
both levels.) but according to the api doc if i understand what you are
describing it would be a bug.

> <patch>
> --- Gtk2/xs/GtkFileSelection.xs.orig    2003-04-17 18:10:53.000000000 -0400
> +++ Gtk2/xs/GtkFileSelection.xs 2003-04-17 18:18:40.000000000 -0400
> @@ -53,3 +53,28 @@
>  #gtk_file_selection_get_selections
>  #      GtkFileSelction * filesel
>
> +GtkWidget*
> +ok_button(fs)
> ...

this function already exists it's named member_widget (something
generic) since we're using the alias stuff there we preferred not to use
one of the specific members as a name for the function, just for the
sake of being clean.

it's great that you're looking at stuff and adding things. it can only
help things get to a mature state faster. 

if you (by that i mean anyone) get bored and want to work on something
that doesn't require knowledge of XS and perlguts then take a stab at
writing a test in the t/ directory. the main thing we're looking to test
are widgets with functions that have custom XS written. there are
several examples in that directory right now that test out things like
window, button, socket/plug, etc. they should be a very good point of
reference in writing such tests. so for anyone that's made use of
gtk-perl before and can look at the xs files to see what's implemented
and needs testing have at it.

-rm