Re: Another Patch (was Re: yet another new snapshot (again))

[Chas Owens <alas widomaker com>]

I took an old Gnome app from before I knew about Gtk::GladeXML and am updating
it to use Gtk2 and Gnome2.  The transition was very minimal, with the exception
of the $app->create_menus.  The helper functions from Gnome::AppHelper do not
appear to be implemented.  I took a brief stab at it, but I need to study XS
more before I can do anything that big.  The only other thing I have noticed so
far is that I could say 

my $sw = Gtk::ScrolledWindow->new;

but now I have to say

my $sw = Gtk::ScrolledWindow->new(
        Gtk2::Adjustment->new(0, 0, 99, 1, 10, 99),
        Gtk2::Adjustment->new(0, 0, 99, 1, 10, 99)
);

I am comparing Gtk-Perl-0.7008 with the latest snapshot right now and I think
the only change that is need is converting this

gtk_scrolled_window_new (class, hadjustment, vadjustment)

to this

gtk_scrolled_window_new (class, hadjustment=0, vadjustment=0)

Of course, I know squat about XS so I am just guessing (the code is compiling as
I write this).  Yup, that did it.  If you don't mind I am going to go through
the code and setup the defaults to match as closely to Gtk-Perl-0.7008's
defaults as I can get them.


Quoting Ross McFarland <rwmcfa1 neces com>:
> thanks, it's been applied. keep them coming if you've got them.
>
> -rm
>
> > --- Gnome2/xs/GnomeProgram.xs.orig      2003-04-16 12:13:18.000000000
> -0400
> > +++ Gnome2/xs/GnomeProgram.xs   2003-04-16 12:13:50.000000000 -0400 @@
> -27,7
> > +27,7 @@
> >                 char * modname = SvPV_nolen (module_info);
> >                 if (strEQ ("libgnomeui", modname)) {
> >                         real_module_info = LIBGNOMEUI_MODULE;
> > -               } else if (streq ("libgnome", modname)) {
> > +               } else if (strEQ ("libgnome", modname)) {
> >                         real_module_info = LIBGNOME_MODULE;
> >                 } else {
> >                         croak ("you passed a string for module_info,
> but it
> > wasn't one of 'libgnomeui' or 'libgnome'");
> >
> >
> > Quoting Emmanuele Bassi <bassi-e libero it>:
> >
> > > * Emmanuele Bassi <bassi-e libero it>:
> > >
> > > I should've spent 60 seconds to track this one... :-)
> > >
> > > Simple typo in Gtk2/xs/GtkNotebook.xs, at line 242. Here's the patch
> that
> > > fixes it:
> > >
> > >
> > > --- Gtk2/xs/GtkNotebook.xs.old     Wed Apr 16 12:31:49 2003
> > > +++ Gtk2/xs/GtkNotebook.xs Wed Apr 16 12:32:04 2003
> > > @@ -240,7 +240,7 @@
> > >    GtkNotebook * notebook
> > >      CODE:
> > >  #if GTK_CHECK_VERSION(2,2,0)
> > > -  RETVAL = gtk_notebook_get_n_pages (notebook)
> > > +  RETVAL = gtk_notebook_get_n_pages (notebook);
> > >  #else
> > >    /* this wasn't defined before 2.2.0...  but it's really handy and
> > >     * easy to implement, like so: */
> > >
> > >
> > > By the way: great job...
> > >
> > > Regards,
> > >  Emmanuele.
> > >
> > > --
> > > Emmanuele Bassi (Zefram)              [
> http://digilander.iol.it/ebassi/ ]
> > > GnuPG Key fingerprint = 4DD0 C90D 4070 F071 5738  08BD 8ECC DB8F A432
> 0FF4
> > > _______________________________________________
> > > gtk-perl-list mailing list
> > > gtk-perl-list gnome org
> > > http://mail.gnome.org/mailman/listinfo/gtk-perl-list
> > _______________________________________________
> > gtk-perl-list mailing list
> > gtk-perl-list gnome org
> > http://mail.gnome.org/mailman/listinfo/gtk-perl-list