Re: more documentation patches



red criticalintegration com writes:

Label.pm is re-patched to use maintainers prefered style
of Gtk2::Label->new("Boo");

Window.pm is new.

Great work. If you give me your sourceforge id (unix name) I can
add you to the gtk2-perl developers so that you may commit by
yourself.


One remaining style comment: it would be nice to have a
consistent code style along the whole documentation (and the
whole sourcecode, which we try as much as we can), and among
others:

- always a space character after the comma when invoking a
  subroutine with multiple parameters, here is ok:

+ =item B<set_default_size($width, $height)>

[...]

here is not:

+     $window->set_default_size(100,200);


- always no () for method invocations without parameters, here is
  ok:

+     $main_window->show;
+     $child_window->show;

[...]

here is not:

+     $window->present();


Other than that, I think this is very nice work.


-- 
Guillaume Cottenceau - http://people.mandrakesoft.com/~gc/



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]