Re: [gtk-osx-devel] Problem with dialog box icons

[John Ralls <jralls ceridwen us>]

On Feb 8, 2014, at 4:54 PM, Jim Charlton <jim jimc dyndns org> wrote:

> On 14-02-08 09:13 AM, Jim Charlton wrote:
> > On 14-02-02 04:49 PM, John Ralls wrote:
> > > On Feb 1, 2014, at 8:19 PM, John Ralls <jralls ceridwen us> wrote:
> > >
> > > > On Feb 1, 2014, at 3:50 PM, Jim Charlton <jim jimc dyndns org> wrote:
> > > >
> > > > > I edited the offending line in gtkselection.c to "return FALSE;" and then meta-gtk-osx-gtk3 built just 
> > > > > fine.
> > > > >
> > > > > jim...
> > > > Good. My faith in you is restored. ;-)
> > > >
> > > > I'll try to get that fixed, backported, and patched tomorrow.
> > > Matthias Classen fixed it right *after* releasing 3.10.7. I’ve added his change set as a patch so builds 
> > > should be automatic. Those who already have a 3.10.7 checkout will need to stop the build and pick “6: 
> > > wipe directory and start over” to apply the patch.
> > >
> > > Regards,
> > > John Ralls
> > A follow-up on the problem of missing MeassageDialog icons.  Even with the new patches (gtk+-3.10.7 
> > gtkmm-3.10.1), I could not get the icons to appear.  I was building and using meta-gtk-osx-gtk3 and 
> > meta-gtk-osx-gtkmm3.  No icons.  I then added 'jhbuild build meta-gtk-osx-core-themes.  After that, 
> > compiling my test code containing
> >
> > Gtk::MessageDialog dialog("Dialog message", FALSE, Gtk::MESSAGE_WARNING, Gtk::BUTTONS_CLOSE);
> > dialog.run();
> >
> > gave a black and white 'dialog-warning' icon.  Not great.... but good enough.
> >
> > jim...   Jim Charlton
>
> Awwww... dang!  I tried again with a brand new installation and when I built meta-gtk-osx-gtk3-core-themes, 
> it did not install anything and the compilation still doesn't give me the icons in the dialog boxes.  I 
> think that the first time I tried this, I removed the gtk+-3.10.7 from the gtk/Source/ directory before 
> building meta-gtk-osx-gtk3-core-themes and this resulted in an older version of gtk+-3 being installed... 
> which did work to give me the icons. Maybe???

Except that removing things from Source doesn't have any affect on what's installed unless you first run make 
uninstall.
Anyway, you don't need to explicitly build meta-gtk-osx-gtk3-core-themes. It's a dependency of 
meta-gtk-osx-gtk3. Just make sure that you're using the latest-and-greatest modulesets.

I just built meta-gtk-osx-gtk3 from scratch and the gnome standard icons show up in the filechooser test, so 
AFAICT the icon-retrieval is working correctly. To check it on your system, start a jhbuild shell, cd to 
Source/gtk+-3.10.7, and run tests/testfilechooser. If the icons are installed correctly, you'll see the 
correct icons in the sidebar; if not, you'll have the red x icons.

Regards,
John Ralls