Re: GtkFontSelection v0.6

[Owen Taylor <otaylor gtk org>]

"Damon Chaplin" <DAChaplin@email.msn.com> writes:

> I've put GtkFontSelection v0.6 at:
> 
>   http://www.comp.lancs.ac.uk/~damon/fontsel/index.html
> 
> I've split it into two widgets - GtkFontSelection & GtkFontSelectionDialog,
> since the Gnome folks want to create their own dialog box conforming
> to their style guidelines.

Further comments:

 - The registry and encoding filters should be combined. Logically,
   one doesn't think of iso8859 and 1, one thinks of iso8859-1.
   (And there is very little use in just viewing fonts in a paricular
   registry, and none in just viewing the fonts in encoding '1')
 
 - I'd still like to have some way of indicating whether there
   is a non-empty filter in effect from the main page. My original
   idea, to have a "clear filter" button (disabled when no filter)
   in the left hand corner of the dialog, is made a bit difficult
   by the division into two widgets, but perhaps something like
   that could be implemented. 

   (Anther possibility, change the color or font of Filter tab label
    when a filter is in effect)

Otherwsise, it is real nice.

> I've also added a tiny program 'gfontsel' which is a self-contained
> font-selector program, rather like xfontsel.

Quite an advance over xfontsel. It would be nice if one didn't
have to go to the font-information page to select the font.

> I think it's practically finished now. Shall I upload it to ftp.gtk.org?
> (Will it go in GTK 1.0.x or does it have to wait til 1.1?)

Only bug fixes are going in 1.0. I think GFontSel in its current
state should go into the 1.1 tree now. 

> PS. There is a warning when compiling:
> 
> gtkfontsel.c:1706: warning: implicit declaration of function
> 	 `gtk_entry_adjust_scroll'
> 
> I had to use gtk_entry_adjust_scroll() since sometimes the text in the
> preview disappeared. Maybe it should be declared in gtkentry.h

I have no idea why this function is public. It shouldn't be.
If you can reproduce how you got the text to disappear, I'll fix it
in gtkentry.c. 

Regards,
                                    Owen