Re: patch for gtkbutton.c

[Owen Taylor <owt1 cornell edu>]

<nuke@bayside.net> writes:

> [1  <text/plain; US-ASCII (7bit)>]
> this is a patch for gtkbutton.c that (IMO) improves the button feel a
> little.. text appears to press along with the button, and when a button is
> held down, the cursor is moved out and back into the button, it represses.
> i just thought we needed something like this :) if the text thing isn't
> in the "gtk nature", just the button press code would be good.
> [2  <text/plain; US-ASCII (base64)>]

I'm not sure what you mean by the button press stuff. It seems
to work that way now, so perhaps it has been fixed since 0.99.3.
If it still doesn't work with the next release, perhaps you
could resubmit your patch (or explain more exactly what you mean)


As for the text motion, well here's a new FAQ entry: [If someone wants
to format this, find a place for it, and put it in the FAQ, it would
be appreciated.]

======

Question: Why don't the contents of a button move when the button
is pressed? Here's a patch to make it work that way...

From: Peter Mattis <petm@scam.XCF.berkeley.edu>

The reason buttons don't move their child down and to the right when
they are depressed is because I don't think that's what is happening
visually. My view of buttons is that you are looking at them straight
on. That is, the user interface lies in a plane and you're above it
looking straight at it. When a button gets pressed it moves directly
away from you. To be absolutely correct I guess the child should
actually shrink a tiny amount. But I don't see why the child should
shift down and to the left. Remember, the child is supposed to be
attached to the buttons surface. Its not good for it to appear like
the child is slipping on the surface of the button. 

On a more practical note, I did implement this at one point and
determined it didn't look good and removed it. 

======

Regards,
                                        Owen