Re: [PATCH] file chooser: Restore consistent click behavior (for gtk 3.20)

[Tomasz Gąsior <mail tomaszgasior kao pl>]

W dniu 2017-10-06 16:41, Matthias Clasen napisał(a):
> On Fri, 2017-10-06 at 09:52 +0200, Tomasz Gąsior wrote:
> > W dniu 2017-10-05 19:02, Matthias Clasen napisał(a):
> > > On Thu, 2017-10-05 at 11:46 +0200, Jean Delvare wrote:
> > > > The change in single-click vs double-click in the GTK 3 file
> > > > chooser
> > > > from commit fb0a13b7f070 ("file chooser: Allow activating without
> > > > double-click") causes more problems than it resolves. There have
> > > > been
> > > > a lot of complaints about it:
> > > >
> > > > * The first item in a directory is selected by default, so a
> > > >   double-click on it misbehaves. Specifically, if that item is a
> > > >   directory, the first click enters the directory, and the second
> > > >   click will apply to whatever is listed first in that directory
> > > >   (which is also selected by default, so effect is immediate.)
> > > > This
> > > >   is unexpected and quite confusing.
> > > > * The ability to activate a selected file or directory with a
> > > > single
> > > >   click interacts badly with selection of multiple files. If you
> > > >   start the selection with a file which was already selected,
> > > > then
> > > >   that file is immediately opened, before you have a chance to
> > > >   complete your selection.
> > > > * This new behavior is inconsistent with Nautilus, GTK 2
> > > > applications
> > > >   (which are sill many) or basically any other existing GUI
> > > > toolkit.
> > > >   Having incompatible behavior between applications is confusing
> > > > for
> > > >   the user.
> > > > * While a number of people are advocating the ban of double-click
> > > > and
> > > >   the use of single-click for everything to make computers easier
> > > > to
> > > >   use by non-tech-savvy people and people with limited abilities,
> > > >   this change does not even achieve that.
> > > >
> > > > If the problem that this change was supposed to address is that
> > > > double-clicking fast is a challenge for some people, this issue
> > > > should be addressed at the desktop environment level, by
> > > > accessibility tools and/or mouse configuration. The GTK 3 file
> > > > chooser is way too high level and specialized to handle this.
> > > >
> > > > So the best thing to do is to revert this change. Ubuntu has
> > > > already
> > > > done so, and SUSE is in the process of doing the same.
> > > >
> > > > https://bugzilla.gnome.org/show_bug.cgi?id=758065
> > > >
> > >
> > > You are just bringing back the complaints about double-click.
> > >
> > > There is no winning here, and I will not support any simple
> > > reversal
> > > unless it comes along with a person who is willing to maintain the
> > > filechooser long-term, and field all the complaints from the 'its
> > > still
> > > not the same as nautilus' crowd.
> > >
> > > IMO the way forward for the file chooser in GTK+ is
> > > GtkFileChooserNative, making this entire mess somebody elses
> > > problem.
> >
> > Can't you just add ability to change single- or double-click behavior
> > in
> > dconf?
> >
> > For example you can create setting
> > "/org/gtk/settings/file-chooser/click-mode" with two possible values
> > "double" or "single".
> > If "click-mode" is set to "double", do nothing because this is
> > default
> > behavior of GtkTreeView. If "click-mode" is set to "single", set
> > "activate-on-single-click" property of GtkTreeView class to "true".
> >
> > It's all. It seems to me it would be simple to maintain in the
> > future.
> > And this way is more consistent — you always have to double-click or
> > single-click. Also you don't have to write a lot of code — all it's
> > needed is in GtkTreeView now.
>
> Adding an option is not a solution at all, thats just a way to avoid
> finding a solution.

Putting ability to control behavior of this thing to the user is the 
best and the simplest solution that we can find.

---
Tomasz Gąsior
https://tomaszgasior.pl