Re: Bug #679291 (please review)
- From: John Lindgren <john lindgren aol com>
- To: Emmanuele Bassi <ebassi gmail com>
- Cc: gtk-devel-list gnome org
- Subject: Re: Bug #679291 (please review)
- Date: Sat, 04 Aug 2012 17:07:27 -0400
On 08/04/2012 04:58 PM, Emmanuele Bassi wrote:
> hi John;
(snip)
> I left a comment in bug 671939, but I can also repeat it here.
>
> the patch in attachment 217892 looks okay - but what I'd like to see:
>
> a) bisecting to see what commit broke this;
> b) a test case for the TreeView test suite, to ensure we don't regress again;
> c) a patch done using git format-patch or git bz, so that we can credit the
> author.
>
> John, would you be so kind to look at this? that would be stellar.
I can write a test case and do a bisect, I think. Are there any
instructions around as to how the test case should be encapsulated
(stand-alone program, C function)?
-- John
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]