Re: commit 52ef73ac8c40ea2a8ca80cf96d52a836bcaf76c2 breaks vmware
- From: Jeff Chua <jeff chua linux gmail com>
- To: Christian Hammond <chipx86 chipx86 com>
- Cc: gtk-devel-list <gtk-devel-list gnome org>, Matthias Clasen <mclasen redhat com>
- Subject: Re: commit 52ef73ac8c40ea2a8ca80cf96d52a836bcaf76c2 breaks vmware
- Date: Wed, 9 Mar 2011 12:43:47 +0800
On Wed, Mar 9, 2011 at 9:10 AM, Christian Hammond <chipx86 chipx86 com> wrote:
> Okay, just to keep people in the loop.
>
> We are indeed doing a couple stupid things with flags. Why it's breaking us,
> I don't know yet (hard to say whether it's specific to a certain version of
> our product, or if it's the fact that I had to just backport this patch to
> test, or that I'm in a devel environment for the product).
>
> So, we have code that wraps some of the option parsing stuff, and it looks
> like we're stupidly defaulting to G_OPTION_FLAG_NO_ARG for a bunch of
> non-callback options. We're also in one place using
> G_OPTION_FLAG_OPTIONAL_ARG without a callback. Clearly wrong, and I'll work
> on a fix for this, but it's still important we identify why exactly it's
> hanging and hopefully keep that from happening (breaking old versions of
> Workstation would be very problematic).
>
> Jeff, what version of Workstation are you running?
Christian,
Vmware Workstation 7.1.3 build-324285.
I'll run with your suggestion above during the flight. I'm waiting for
my plane at the airport now.
Thanks,
Jeff
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]