Make G_FILE_MONITOR_EVENT_CHANGES_DONE_HINT only emitted on close()



Hi hi,

Currently, G_FILE_MONITOR_EVENT_CHANGES_DONE_HINT is issued in two
cases:
 * If a file is updated, not closed, and the last update happened more
than 2 seconds ago (hardcoded value).
 * If a file is updated and closed.

After a discussion in IRC, it was suggested (Company, kalikiana,
walters...) that this emission of virtual CHANGES_DONE_HINT events
should be fully removed, so that the event is only sent on file close().

The virtual CHANGES_DONE_HINT emission can be done, if needed, by the
application using GFileMonitor, refreshing a timeout every time a
CHANGED event is received, as currently done by the GFileMonitor
internally.

For an example of the current glib master behavior and the new one if
the virtual emission is removed, see
https://bugzilla.gnome.org/show_bug.cgi?id=635765#c11

During the discussion it was also suggested deprecating
g_file_monitor_set_rate_limit().

Anyone with comments about these issues?

Where's this virtual emission of CHANGES_DONE_HINT coming from
originally?

Cheers!

-- 
Aleksander



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]