GNOME.org

Re: [PATCH] GKeyFile: Switch gint to gint64

From: Tor Lillqvist <tml iki fi>
To: Andy Spencer <andy753421 gmail com>
Cc: gtk-devel-list gnome org
Subject: Re: [PATCH] GKeyFile: Switch gint to gint64
Date: Fri, 2 Apr 2010 14:24:03 +0300

> You could also add separate get/set functions for longlong or int64,

That is obviously the correct way to do it. Your patch would break API.

You patch uses strtoll() unconditionally, and you use %lld to printf
gint64 values. Neither is portable. Use g_ascii_strtoll() and
G_GINT64_FORMAT.

--tml

Follow-Ups:
- Re: [PATCH] GKeyFile: Switch gint to gint64
  - From: Simon McVittie

References:
- [PATCH] GKeyFile: Switch gint to gint64
  - From: Andy Spencer

[Date Prev][Date Next] [Thread Prev][Thread Next] [Thread Index] [Date Index] [Author Index]