Re: Supporting Gtk+ Maintenance

["Matthias Clasen" <matthias clasen gmail com>]

On 3/15/07, Federico Mena Quintero <federico ximian com> wrote:

> Your mission, should you decide to accept it, is to do this:
>
> - Get the latest GTK+ from svn trunk.
>
> - Go through each of the unreviewed patches and classify them
> informally:
>
>         - obsolete patch which does not apply "as-is" to the sources
>           (you can use "patch --dry-run" to test this easily without
>           screwing up your source tree)
>         - big patch which needs detailed testing/review
>         - small patch which could be tested/reviewed in a few minutes

I see that somebody took up this task now. While I appreciate the effort,
I don't think that a mere applies/doesn't apply  small/big classification of
patches helps _that_ much with the patch review.

I have started a small patch review checklist in
http://live.gnome.org/GtkTasks#P1
that should help people who want to bring patches in good shape.

Matthias