Re: RFC: warnings on ignoring return value on some list operations

["Gustavo J. A. M. Carneiro" <gjc inescporto pt>]

Qui, 2005-11-24 às 16:35 +0100, Tim Janik escreveu:
> On Thu, 24 Nov 2005, Owen Taylor wrote:
> 
> > if (head) {
> >    g_list_append(tail, new);
> >    tail = tail->next;
> > } else {
> >    head = tail = g_list_append(null, new);
> > }
> >
> > strikes me as acceptable code, and I know there are some examples like this
> > in GTK+. Maybe the gain is worth the pain ... unless someone is compiling
> > production code with -Werror it isn't going to *break* a build, and there
> > is no bin-compat issue. But it's definitely a compatibility break of some
> > sort.
> 
> i think one can argue both ways here, in the above code, i'd still write
> head = g_list_append (tail, new); and recommend that people also do that,
> because a) code is duplicated so often and this easily introduces errors
> in another context, and b) i'd like to think of the list API as something
> where i'm not allowed to ignore return values to avoid mistakes ;)
> 
> >
> > Does
> >
> >   (void)g_list_append(tail, new);
> >
> > Suppress the warning?
> 
> i was assuming that, unfortunately that is not the case:

  I don't see how:

	(void)g_list_append(tail, new);

is any better than:

	tail = g_list_append(tail, new);

and that still leaves the option:

	GList *dummy = g_list_append(tail, new);

  With more or less typing, this is an easy warning to fix.  And don't
get me started again about the evil of -Werror :P

-- 
Gustavo J. A. M. Carneiro
<gjc inescporto pt> <gustavo users sourceforge net>
The universe is always one step beyond logic.