Re: RFC: warnings on ignoring return value on some list operations
- From: Tim Janik <timj imendio com>
- To: Owen Taylor <otaylor redhat com>
- Cc: "gtk-devel-list gnome org" <gtk-devel-list gnome org>, Alexander Larsson <alexl redhat com>
- Subject: Re: RFC: warnings on ignoring return value on some list operations
- Date: Thu, 24 Nov 2005 15:50:29 +0100 (CET)
On Thu, 24 Nov 2005, Owen Taylor wrote:
On Thu, 2005-11-24 at 11:58 +0100, Tim Janik wrote:
i think that is a really good idea. however i'm more of the opinion that all
list functions should have the warn_unused_result tag. code and conditions
are easily changed, moved around or pasted so that missing the return value
assignment for lists will become a problem. i.e. even if you know you're
appending to a non-empty list, you should still write
list = g_list_append (list, data);
so i'd apprchiate if you extended the patch to cover all list functions
that return possibly modified lists ;)
What happened to compatibility?
could you please outline how you see compatibility affected by this?
Owen
---
ciaoTJ
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]