That's correct, this hardcoded limit is definitely meaningless for a general purpose integer filter. I actually tried to add a property by looking at what is done in similar code. Unfortunately I'm really not an expert of gtk and ended up with my new property's value being stuck at zero. I attach this broken patch for the case you'd like to review it and maybe spot a trivial mistake... Louis-Marie 2013/4/3 Paolo Bacchilega <paolo bacchilega libero it>:
Il 03/04/2013 19:25, Louis-Marie Mouton ha scritto:Hi, Looking around for filtering my photos based on their rating value, I ended up with these two patches (tested on 3.0.2 but seem to cleanly apply on current master). I'm not familiar with gthumb contribution process, but in case the patches may be helpful I would be happy to have them merged into the master. Just let me know if I can improve them for integration... Louis-MarieThe patch looks good to me, the only doubt I have is about the hard-coded limit of 5, maybe it's better to add a property to GthTestSimple to specify the maximum value. - Paolo _______________________________________________ gthumb-list mailing list gthumb-list gnome org https://mail.gnome.org/mailman/listinfo/gthumb-list
Attachment:
0001-Add-int-max-property-to-define-upper-range-limit-of-.patch
Description: Binary data