Re: [gthumb-list] "hotkey unwork" bugs
- From: Matthias Hawran <matthias hawran net>
- To: gthumb-list gnome org
- Subject: Re: [gthumb-list] "hotkey unwork" bugs
- Date: Fri, 26 Feb 2010 10:35:03 +0100
Paolo Bacchilega a écrit :
Matthias Hawran ha scritto:
I saw your fix for Bug 575036.
I'll be able to continue with the rest.
I won't do a global patch, but intermediate patches.
I'll attach them here, since they'll cover several bug reports.
Here's the one for
- metadata dialog (bug 575037)
- import pref dialog (bug 575048)
- photo importer dialog (bug 575050)
Let me know if it's ok, so I can continue.
the patch looks good to me
Paolo
More fixes:
- rename dialog (bug 575053)
- crop dialog (bug 575160)
- red eye dialog (bug 575166)
Also I was looking at the "adjust colors" dialog and I was wondering if
it wouldn't be more simple
to remove the mnemonics for all the 7 parameters (but keep the ones on
the buttons)
This because of conflicting letters shortcut with the general menu, as
the dialog is in the same focus.
So for example 'g' and 'b' are taken for 'Go' and 'Bookmarks'
Also because one needs to find 7 different letters which can lead to
awkward choices.
What do you think ?
Matthias
From 71de81487b16055d02ba1938158847b29f9beb8c Mon Sep 17 00:00:00 2001
From: Matthias Hawran <matthias hawran net>
Date: Fri, 26 Feb 2010 10:32:50 +0100
Subject: [PATCH 2/2] Several mnemonic fixes:
- rename dialog (bug 575053)
- crop dialog (bug 575160)
- red eye dialog (bug 575166)
---
.../file_tools/data/ui/adjust-colors-options.ui | 14 +++++++-------
extensions/file_tools/data/ui/crop-options.ui | 16 ++++++++++------
.../data/ui/red-eye-removal-options.ui | 6 ++++--
extensions/rename_series/data/ui/rename-series.ui | 18 +++++++++---------
extensions/rename_series/dlg-rename-series.c | 2 ++
5 files changed, 32 insertions(+), 24 deletions(-)
diff --git a/extensions/file_tools/data/ui/adjust-colors-options.ui
b/extensions/file_tools/data/ui/adjust-colors-options.ui
index 0099a5d..f42e310 100644
--- a/extensions/file_tools/data/ui/adjust-colors-options.ui
+++ b/extensions/file_tools/data/ui/adjust-colors-options.ui
@@ -35,7 +35,7 @@
<property name="column_spacing">6</property>
<property name="row_spacing">6</property>
<child>
- <object class="GtkLabel" id="label1">
+ <object class="GtkLabel" id="brightness_label">
<property name="visible">True</property>
<property name="xalign">0</property>
<property name="label" translatable="yes">_Brightness:</property>
@@ -48,7 +48,7 @@
</packing>
</child>
<child>
- <object class="GtkLabel" id="label2">
+ <object class="GtkLabel" id="contrast_label">
<property name="visible">True</property>
<property name="xalign">0</property>
<property name="label" translatable="yes">Con_trast:</property>
@@ -61,7 +61,7 @@
</packing>
</child>
<child>
- <object class="GtkLabel" id="label3">
+ <object class="GtkLabel" id="saturation_label">
<property name="visible">True</property>
<property name="xalign">0</property>
<property name="label" translatable="yes">_Saturation:</property>
@@ -128,7 +128,7 @@
</packing>
</child>
<child>
- <object class="GtkLabel" id="label4">
+ <object class="GtkLabel" id="gamma_label">
<property name="visible">True</property>
<property name="xalign">0</property>
<property name="label" translatable="yes">_Gamma:</property>
@@ -139,7 +139,7 @@
</packing>
</child>
<child>
- <object class="GtkLabel" id="label6">
+ <object class="GtkLabel" id="cyan_red_label">
<property name="visible">True</property>
<property name="xalign">0</property>
<property name="label" translatable="yes">Cyan-_Red:</property>
@@ -152,7 +152,7 @@
</packing>
</child>
<child>
- <object class="GtkLabel" id="label7">
+ <object class="GtkLabel" id="magenta_green_label">
<property name="visible">True</property>
<property name="xalign">0</property>
<property name="label" translatable="yes">_Magenta-Green:</property>
@@ -165,7 +165,7 @@
</packing>
</child>
<child>
- <object class="GtkLabel" id="label8">
+ <object class="GtkLabel" id="yellow_blue_label">
<property name="visible">True</property>
<property name="xalign">0</property>
<property name="label" translatable="yes">_Yellow-Blue:</property>
diff --git a/extensions/file_tools/data/ui/crop-options.ui b/extensions/file_tools/data/ui/crop-options.ui
index c81344c..c7c395a 100644
--- a/extensions/file_tools/data/ui/crop-options.ui
+++ b/extensions/file_tools/data/ui/crop-options.ui
@@ -36,11 +36,12 @@
<property name="column_spacing">6</property>
<property name="row_spacing">6</property>
<child>
- <object class="GtkLabel" id="label3">
+ <object class="GtkLabel" id="crop_x_label">
<property name="visible">True</property>
<property name="xalign">0</property>
<property name="label" translatable="yes">_X:</property>
<property name="use_underline">True</property>
+ <property name="mnemonic_widget">crop_x_spinbutton</property>
</object>
<packing>
<property name="x_options">GTK_FILL</property>
@@ -48,11 +49,12 @@
</packing>
</child>
<child>
- <object class="GtkLabel" id="label5">
+ <object class="GtkLabel" id="crop_y_label">
<property name="visible">True</property>
<property name="xalign">0</property>
<property name="label" translatable="yes">_Y:</property>
<property name="use_underline">True</property>
+ <property name="mnemonic_widget">crop_y_spinbutton</property>
</object>
<packing>
<property name="top_attach">1</property>
@@ -62,11 +64,12 @@
</packing>
</child>
<child>
- <object class="GtkLabel" id="label4">
+ <object class="GtkLabel" id="crop_width_label">
<property name="visible">True</property>
<property name="xalign">0</property>
<property name="label" translatable="yes">_Width:</property>
<property name="use_underline">True</property>
+ <property name="mnemonic_widget">crop_width_spinbutton</property>
</object>
<packing>
<property name="top_attach">2</property>
@@ -76,11 +79,12 @@
</packing>
</child>
<child>
- <object class="GtkLabel" id="label6">
+ <object class="GtkLabel" id="crop_height_label">
<property name="visible">True</property>
<property name="xalign">0</property>
- <property name="label" translatable="yes">_Height:</property>
+ <property name="label" translatable="yes">Heigh_t:</property>
<property name="use_underline">True</property>
+ <property name="mnemonic_widget">crop_height_spinbutton</property>
</object>
<packing>
<property name="top_attach">3</property>
@@ -353,7 +357,7 @@
<property name="layout_style">center</property>
<child>
<object class="GtkButton" id="crop_button">
- <property name="label" translatable="yes">_Crop</property>
+ <property name="label" translatable="yes">C_rop</property>
<property name="visible">True</property>
<property name="can_focus">True</property>
<property name="receives_default">True</property>
diff --git a/extensions/red_eye_removal/data/ui/red-eye-removal-options.ui
b/extensions/red_eye_removal/data/ui/red-eye-removal-options.ui
index ef8a62d..b2f8102 100644
--- a/extensions/red_eye_removal/data/ui/red-eye-removal-options.ui
+++ b/extensions/red_eye_removal/data/ui/red-eye-removal-options.ui
@@ -36,11 +36,12 @@
<property name="column_spacing">6</property>
<property name="row_spacing">6</property>
<child>
- <object class="GtkLabel" id="label3">
+ <object class="GtkLabel" id="x_label">
<property name="visible">True</property>
<property name="xalign">0</property>
<property name="label" translatable="yes">_X:</property>
<property name="use_underline">True</property>
+ <property name="mnemonic_widget">x_spinbutton</property>
</object>
<packing>
<property name="x_options">GTK_FILL</property>
@@ -48,11 +49,12 @@
</packing>
</child>
<child>
- <object class="GtkLabel" id="label5">
+ <object class="GtkLabel" id="y_label">
<property name="visible">True</property>
<property name="xalign">0</property>
<property name="label" translatable="yes">_Y:</property>
<property name="use_underline">True</property>
+ <property name="mnemonic_widget">y_spinbutton</property>
</object>
<packing>
<property name="top_attach">1</property>
diff --git a/extensions/rename_series/data/ui/rename-series.ui
b/extensions/rename_series/data/ui/rename-series.ui
index e4ca46f..03122c6 100644
--- a/extensions/rename_series/data/ui/rename-series.ui
+++ b/extensions/rename_series/data/ui/rename-series.ui
@@ -26,7 +26,7 @@
<property name="column_spacing">12</property>
<property name="row_spacing">6</property>
<child>
- <object class="GtkLabel" id="label7">
+ <object class="GtkLabel" id="start_at_label">
<property name="visible">True</property>
<property name="xalign">0</property>
<property name="label" translatable="yes">Start _at:</property>
@@ -41,7 +41,7 @@
</packing>
</child>
<child>
- <object class="GtkLabel" id="label5">
+ <object class="GtkLabel" id="sort_by_label">
<property name="visible">True</property>
<property name="xalign">0</property>
<property name="label" translatable="yes">_Sort by:</property>
@@ -55,7 +55,7 @@
</packing>
</child>
<child>
- <object class="GtkLabel" id="label123">
+ <object class="GtkLabel" id="change_case_label">
<property name="visible">True</property>
<property name="xalign">0</property>
<property name="label" translatable="yes" comments="Translators: this is the text case
(upper or lower case).">Cas_e:</property>
@@ -386,11 +386,12 @@
<property name="visible">True</property>
<property name="orientation">vertical</property>
<child>
- <object class="GtkLabel" id="label1">
+ <object class="GtkLabel" id="template_label">
<property name="visible">True</property>
<property name="xalign">0</property>
<property name="label" translatable="yes">_Template:</property>
<property name="use_underline">True</property>
+ <property name="mnemonic_widget">template_entry</property>
</object>
<packing>
<property name="expand">False</property>
@@ -444,12 +445,11 @@
<property name="orientation">vertical</property>
<property name="spacing">6</property>
<child>
- <object class="GtkLabel" id="label69">
+ <object class="GtkLabel" id="preview_label">
<property name="visible">True</property>
<property name="xalign">0</property>
- <property name="label" translatable="yes">_Preview:</property>
+ <property name="label" translatable="yes">Preview:</property>
<property name="use_markup">True</property>
- <property name="use_underline">True</property>
</object>
<packing>
<property name="expand">False</property>
@@ -556,13 +556,13 @@
<object class="GtkSizeGroup" id="sizegroup1">
<property name="mode">vertical</property>
<widgets>
- <widget name="label1"/>
<widget name="template_entry"/>
+ <widget name="template_label"/>
</widgets>
</object>
<object class="GtkAdjustment" id="start_at_adjustment">
- <property name="upper">1000000000</property>
<property name="value">1</property>
+ <property name="upper">1000000000</property>
<property name="step_increment">1</property>
<property name="page_increment">10</property>
</object>
diff --git a/extensions/rename_series/dlg-rename-series.c b/extensions/rename_series/dlg-rename-series.c
index 46a3bdc..e1beb3c 100644
--- a/extensions/rename_series/dlg-rename-series.c
+++ b/extensions/rename_series/dlg-rename-series.c
@@ -476,6 +476,7 @@ dlg_rename_series (GthBrowser *browser,
gtk_combo_box_set_active (GTK_COMBO_BOX (data->sort_combobox), 0);
gtk_widget_show (data->sort_combobox);
gtk_container_add (GTK_CONTAINER (GET_WIDGET ("sort_by_box")), data->sort_combobox);
+ gtk_label_set_mnemonic_widget (GTK_LABEL (GET_WIDGET ("sort_by_label")), data->sort_combobox);
/* change case */
@@ -486,6 +487,7 @@ dlg_rename_series (GthBrowser *browser,
gtk_combo_box_set_active (GTK_COMBO_BOX (data->change_case_combobox), 0);
gtk_widget_show (data->change_case_combobox);
gtk_container_add (GTK_CONTAINER (GET_WIDGET ("change_case_box")), data->change_case_combobox);
+ gtk_label_set_mnemonic_widget (GTK_LABEL (GET_WIDGET ("change_case_label")),
data->change_case_combobox);
dlg_rename_series_update_preview (data);
--
1.6.3.3
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]
