[gthumb-list] "hotkey unwork" bugs

[Matthias Hawran <matthias hawran net>]

Hi all,

I'm looking at the 18 "hotkey unwork" bugs (#575036 and on)
which basically address the same issue:
the mnemonic is not always set or half set.

Some are easy to fix, in glade you just need to set the "Mnemonic widget"
in the label general properties tab, which adds the following line:
<property name="mnemonic_widget">xxxx</property>

However when the widget is a Box, like a GtkHBox for example it's not so
straightforward.

As an example, let's take *Bug 575036*
<https://bugzilla.gnome.org/show_bug.cgi?id=575036>
It's in the search function.
Alt+a, for the "Start at" widget doesn't work.
You would naturally set the mnemonic widget to "location_box", except
it's a GtkHBox.
Which gives you the following execution warning:

(gthumb:8205): Gtk-WARNING **: widget `GtkHBox' isn't suitable for
mnemonic activation

In the same part, I then looked at how the "Match" mnemonic worked,
since the glade had no "mnemonic_widget" property.
It's done in the code with the "gtk_label_set_mnemonic_widget" function

extensions/search/gth-search-editor.c:148
gtk_label_set_mnemonic_widget (GTK_LABEL (GET_WIDGET ("match_label")),
self->priv->match_type_combobox);

Ok so let's do this for the "Start at":

gtk_label_set_mnemonic_widget (GTK_LABEL (GET_WIDGET
("start_at_label")), self->priv->location_chooser);

Not better, I get:

(gthumb:9007): Gtk-WARNING **: widget `GthLocationChooser' isn't
suitable for mnemonic activation


And now I'm stuck :-)

But maybe there's no solution to get a mnemonic for such case ?
In that case we should remove the "use underline" property,
which makes you think there is one.

I'll fix all the others I can and prepare a global patch for all the bugs,
what do you think (of the global patch idea) ?

Thanks for reading so far.

Cheers,
Matthias