Re: [PATCH] metadata-keys: add metadata keys from camera pictures




On Thu, 17 Mar 2011 16:57:15 +0100, "Juan A." Suárez Romero <jasuarez igalia com> wrote:
On Thu, 2011-03-17 at 11:35 +0000, Lionel Landwerlin wrote:
> > c) Get rid of GRL_METADATA_KEY_DATE and add
> > GRL_METADATA_KEY_CREATION_DATE and GRL_METADATA_KEY_INSERTION_DATE ?
> >
> > d) Add GRL_METADATA_KEY_CREATION_DATE and
> > GRL_METADATA_KEY_INSERTION_DATE and make GRL_METADATA_KEY_DATE related
> > to one of them (is that possible ?)
> >
>
> Yes that could be possible too.
>
> Thus, is up to the source to determine the meaning of
> GRL_METADATA_KEY_DATE.
>
> 	J.A.

I rather see that as a compatibility transition to not break everything.
With the related key being a statement made by the Grilo framework.



Ok. So to close this thread, here is a proposal:

1) Add new GRL_METADATA_KEY_CREATION_DATE and
GRL_METADATA_KEY_INSERTION_DATE

2) Leave GRL_METADATA_KEY_DATE as it is now: defined by source


Is anyone against this? Note that proposal tries, as Lionel said, not to
break what we have right now.

I think this is ok. BTW, someone else mentioned before that we should add proper documentation explaining the purpose of each key. In most cases they are fairly obvious, but in some, like this, it is nice to explain the exact purpose of the keys with a bit more detail so that everyone is on the same page when developing plugins or apps using these keys, I think we should that to our short-term ToDo.

Iago


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]