Re: [PATCH 2/6] core: changed type of date keys to GDateTime



On Wed, 2011-06-22 at 19:07 +0200, Guillaume Emont wrote:
> +grl_media_set_date (GrlMedia *media, const GDateTime *date)

I would drop the 'const' prefix from that parameter.

I've been looking at other functions that use a constant GDateTime
(mainly, the GDateTime functions themselves), and none of them is
prefixing the parameter with a 'const', even when the parameter is never
modified.

I only see the use of const for string parameters.

Anyway, this is a minor personal preference :)

	J.A.




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]