Re: [PATCH 4/4] upnp: support GrlMediaSourceClass->query
- From: "Juan A." Suárez Romero <jasuarez igalia com>
- To: grilo-list gnome org
- Subject: Re: [PATCH 4/4] upnp: support GrlMediaSourceClass->query
- Date: Mon, 17 Jan 2011 21:43:53 +0100
On Thu, 2011-01-13 at 13:53 +0200, Jussi Kukkonen wrote:
> + "StartingIndex", G_TYPE_UINT,
> + 0,
>
I'm not an UPnP expert, but shouldn't "StartingIndex" be qs->skip
instead of 0?
I've seen also that search() uses 0 as the StartingIndex instead of
ss->skip, so I'm not very sure if it's a bug or not.
Other than that, patch looks good for me.
J.A.
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]