Re: [PATCH 4/4] upnp: support GrlMediaSourceClass->query

[Jussi Kukkonen <jku linux intel com>]

On 01/17/2011 10:43 PM, Juan A. Suárez Romero wrote:
> On Thu, 2011-01-13 at 13:53 +0200, Jussi Kukkonen wrote:
>> +                                     "StartingIndex", G_TYPE_UINT,
>> +                                     0,
>>
> 
> I'm not an UPnP expert, but shouldn't "StartingIndex" be qs->skip
> instead of 0?
> 
> I've seen also that search() uses 0 as the StartingIndex instead of
> ss->skip, so I'm not very sure if it's a bug or not.
> 

Yeah, definitely a bug, thanks... I also now see how I had trouble
noticing this: it looks like grilo-test-ui has a bug where it ends up
calling search() when it should call query() and it's also limited to
two consecutive calls at the moment.

I'll cook up a new patch for this, possibly improvements for the
test-ui, and send the leak fixes as well.

Jussi