Re: [PATCH 0/6] Misc fixes and improved annotations

[Iago Toral <itoral igalia com>]

On Tue, 7 Sep 2010 10:44:02 +0200, Simón Pena Placer <spenap gmail com>
wrote:
> On 7 September 2010 09:30, Iago Toral <itoral igalia com> wrote:
>>
>> On Mon,  6 Sep 2010 19:04:10 +0200, Simón Pena <spenap gmail com>
>> wrote:
>>> Hi,
>>>
>>> The following patches continue improving introspection support,
>>> completing GrlMediaPlugin and GrlMetadataSource classes, and replacing
>>> with functions some functionality in GrlMediaPlugin previously only
>>> accessible
>>> via macros.
>>>
>>> Regarding to that, I'd like to ask you to check the functions dealing
>>> with GLists in the
>>> GrlMetadataSource: I've annotated them with (transfer none),
>>> (transfer container)
>>> and (transfer full) depending on who owns those lists after calling
>>> the functions,
>>> by looking at the code and existing documentation. However, I could be wrong.
>>
>> I was checking this and I wonder about those "transfer full" for some
>> functions returning GLists of keys (example:
>> grl_metadata_source_filter_supported). If I understand correctly,
>> "transfer full" means that the client should free both the container and
>> the content, right? But it is my understanding that we should never free
>> the actual keys (for they are static pointers)... or am I missing
>> something?
> 
> You're completely right: those are incorrectly annotated, as the
> actual keys should never be freed. Thanks, I'll correct that in the
> afternoon :)

BTW, since these annotations were already in the repo maybe I can push
this set of patches now  and then push your patches to fix this issue
separately. Whatever is easier for you.

Iago