[PATCH 0/6] Misc fixes and improved annotations
- From: Simón Pena <spenap gmail com>
- To: grilo-list gnome org
- Subject: [PATCH 0/6] Misc fixes and improved annotations
- Date: Mon, 6 Sep 2010 19:04:10 +0200
Hi,
The following patches continue improving introspection support,
completing GrlMediaPlugin and GrlMetadataSource classes, and replacing
with functions some functionality in GrlMediaPlugin previously only accessible
via macros.
Regarding to that, I'd like to ask you to check the functions dealing with GLists in the
GrlMetadataSource: I've annotated them with (transfer none), (transfer container)
and (transfer full) depending on who owns those lists after calling the functions,
by looking at the code and existing documentation. However, I could be wrong.
Besides, when invoking a plugin 'key-depends' method, a check is introduced
so it doesn't fail when that plugin hasn't implemented the method.
I'm now preparing the unit tests: I've been using them to find these issues,
but still have to move them to the /test/python directory and fix them to
work in an uninstalled environment --I did some incorrect assumptions which would
make the tests fail when invoked uninstalled.
Cheers,
Simón Pena (6):
annotations: Fixed 'get_info_keys' annotation
core: Replaced grl-media-plugin defines with functions
annotations: Annotated grl-metadata-source
annotations: Annotated metadata_source cb GErrors as uints
annotations: Minor fix: added missing colon
core: Checked for 'key-depends' implementation
src/data/grl-data.c | 2 +-
src/grl-media-plugin.c | 93 ++++++++++++++++++++++++++++++++++++++++++++-
src/grl-media-plugin.h | 78 ++++---------------------------------
src/grl-metadata-source.c | 65 ++++++++++++++++++++------------
src/grl-metadata-source.h | 7 ++-
5 files changed, 147 insertions(+), 98 deletions(-)
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]