Hi, On Thu, 2010-06-17 at 16:11 +0200, Juan A. Suarez Romero wrote: > On Thu, 2010-06-17 at 14:11 +0200, Joaquim Rocha wrote: > > > > About the ID being in the configure, I don't have a strong opinion, > > obviously, in the code its clearer but in order to avoid repetition > > I've > > done that with autotools. Of course, this is our set of plugins, other > > developers can use another way to set the XML's name and plugin's ID. > > Me neither. > > It is true that having the ID defined in the configure.ac makes more > sense if one thinks that the ID can be changed when building the source, > the same way as other elements for Grilo core are defined in > configure.ac (default plugins dir, Grilo api version, ...). > > Other than that, I don't see any other advantage of defining them in > configure.ac > Like I said, in case of applying these changes, it has the advantage of not repeating that constant. So, how do we solve this? ID or no ID as the XML names? If we go with the No ID, I'll change the patches to use the plugin's file names but look for them the new folder. -- Joaquim Rocha
Attachment:
signature.asc
Description: This is a digitally signed message part