Re: [PATCH 0/2] Move and rename the plugins' XML file



On Thu, 2010-06-17 at 14:11 +0200, Joaquim Rocha wrote:
> I think it is better to be able to give a different name to the XML
> than
> the libraries' compiled prefix.
> I think the ID is a more appropriate name for the XML file because the
> ID is what identifies a plugin, not its compiled name.

As I said, I don't have any strong reason to prefer one or another
approach.

> 
> About the ID being in the configure, I don't have a strong opinion,
> obviously, in the code its clearer but in order to avoid repetition
> I've
> done that with autotools. Of course, this is our set of plugins, other
> developers can use another way to set the XML's name and plugin's ID. 

Me neither.

It is true that having the ID defined in the configure.ac makes more
sense if one thinks that the ID can be changed when building the source,
the same way as other elements for Grilo core are defined in
configure.ac (default plugins dir, Grilo api version, ...).

Other than that, I don't see any other advantage of defining them in
configure.ac

	J.A.




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]