Re: [PATCH 0/2] Move and rename the plugins' XML file



On Tue, 15 Jun 2010 19:14:32 +0200, Joaquim Rocha <jrocha igalia com>
wrote:
> Hi,
> 
> Regarding the last changes that used an XML file to represent plugins'
> information, that XML file needed to have the same name as its plugin
> (that is, the name of the library: lib....xml) and exist under the same
> directory as well.
> 
> This approach is not very clean in the way that it mixes the libraries
> with the XML files. Plus, it restricts the XML name to the library's
> one.

I think mapping the library name and the xml name is not a problem, actually 
I think it is better: knowing one you know the other. Also, I don't see any 
benefit in being able to have a different name for the xml file, which is also 
constraint to the plugin id now anyway...

And with this approach we have to define the plugin ids in the configure.ac 
file instead of defining them in the plugin code... not sure if I like that 
either. 

> This patch introduces a directory to hold the plugins' XML files and
> will expect the files to have the plugin's ID (with the xml extension)
> instead.

Having a separate directory for the configuration is ok with me.

> I'll also upload the changes for the apple-trailers' plugin.
> 
> Since the rest that's to be done is repetitive work, I'd like to hear
> your opinions about these changes before I do the changes to the
> remaining plugins.

Iago


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]